Closed Bug 1054043 Opened 5 years ago Closed 5 years ago

[10.10] Bad CPU type in executable running mochitests on yosemite

Categories

(Core :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
firefox34 --- fixed
firefox-esr31 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

Building on MacOS X 10.10, I get an executable which runs. However, './mach mochitest-plain' fails with:

INFO arch: posix_spawnp: /Users/mozilla/firefox/obj-x86_64-apple-darwin14.0.0/dist/NightlyDebug.app/Contents/MacOS/firefox: Bad CPU type in executable
Duplicate of this bug: 1054042
Hah, getting screwed by this:
http://hg.mozilla.org/mozilla-central/annotate/5299864050ee/build/automationutils.py#l405

We should just rip wrapCommand out of all our automation, it was only needed for 10.5 support. It just needs to be removed from automationutils.py and here:
http://hg.mozilla.org/mozilla-central/annotate/5299864050ee/build/automation.py.in#l220
That would make test! The version check is string based so "10.10" < "10.5";

But I tried removing it and I still get this:

1 INFO arch: posix_spawnp: /Users/akachkach/workspace/gecko-dev/obj-x86_64-apple-darwin14.0.0/dist/Nightly.app/Contents/MacOS/firefox: Bad CPU type in executable
TEST-INFO | Main app process: killed by SIGHUP
Patch as described. Doesn't fix the problem for me either; trying a clobber build.
Assignee: nobody → giles
Attachment #8473325 - Flags: review?(ted)
The same code is in mozrunner.
Attachment #8473328 - Flags: review?(ahalberstadt)
Attachment #8473325 - Attachment is patch: true
With these two patches I'm able to './mach mochitests-plain' on osx yosemite.
Same here, the mozrunner patch made it. (and this is why you don't compare version numbers as strings or numbers! :))

Thanks rillian!
Comment on attachment 8473325 [details] [diff] [review]
Remove wrapcommand

Yeah, it was just a terrible hack that outlived its usefulness. Sorry about that!
Attachment #8473325 - Flags: review?(ted) → review+
Attachment #8473328 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/542ad6da24a5
https://hg.mozilla.org/mozilla-central/rev/e3ba56da078a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
Comment on attachment 8473328 [details] [diff] [review]
Remove 32-bit wrapper from mozrunner

Need this to run mochitests on esr31 Yosemite.
Attachment #8473328 - Flags: approval-mozilla-esr31?
Attachment #8473328 - Flags: approval-mozilla-esr31? → approval-mozilla-esr31+
You need to log in before you can comment on or make changes to this bug.