Closed Bug 1054099 Opened 11 years ago Closed 11 years ago

Remove use of gradients in new tab page

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 35
Iteration:
35.2
Tracking Flags:
Tracking Status
firefox33 + verified
firefox34 --- verified
firefox35 --- verified

People

(Reporter: Mardak, Assigned: ttaubert)

References

Details

Attachments

(1 file)

0001-Bug-1054099-Remove-use-of-gradients-in-new-tab-page-.patch
1.23 KB, patch
dao
: review+
lmandel
: approval-mozilla-aurora+
lmandel
: approval-mozilla-beta+
Details | Diff | Splinter Review
From bug 1044602 comment 30: pwd says nothing else in the primary or secondary ui except reload makes use of gradients.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8492583 - Flags: review?(edilee)
Iteration: --- → 35.2
Points: --- → 1
QA Whiteboard: [qa+]
Comment on attachment 8492583 [details] [diff] [review] 0001-Bug-1054099-Remove-use-of-gradients-in-new-tab-page-.patch Yay! I found those gradients quite unpleasant. Stealing review...
Attachment #8492583 - Flags: review?(edilee) → review+
https://hg.mozilla.org/mozilla-central/rev/62b99394e46b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8492583 [details] [diff] [review] 0001-Bug-1054099-Remove-use-of-gradients-in-new-tab-page-.patch Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: White gradients over newtab page tiles. [Describe test coverage new/current, TBPL]: CSS removal, no test coverage necessary. [Risks and why]: Zarro reesk. UX wants these gradients gone before tiles go to GA. [String/UUID change made/needed]: None.
Attachment #8492583 - Flags: approval-mozilla-beta?
Attachment #8492583 - Flags: approval-mozilla-aurora?
Comment on attachment 8492583 [details] [diff] [review] 0001-Bug-1054099-Remove-use-of-gradients-in-new-tab-page-.patch Simple tiles change. Approved for Beta and Aurora.
Attachment #8492583 - Flags: approval-mozilla-beta?
Attachment #8492583 - Flags: approval-mozilla-beta+
Attachment #8492583 - Flags: approval-mozilla-aurora?
Attachment #8492583 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
QA Contact: cornel.ionce
Verified that the gradients are properly removed from the new tab page on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 using: 1. Latest Nightly, build ID: 20140924030204 2. Latest Aurora, build ID: 20140924004001 3. Firefox 33 beta 7, build ID: 20140923222114
Status: RESOLVED → VERIFIED
status-firefox33: fixed → verified
status-firefox34: fixed → verified
status-firefox35: fixed → verified
Blocks: 1050643
QA Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: