Closed
Bug 1054129
Opened 11 years ago
Closed 11 years ago
Set options.success automatically in sendChromeMessage()
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 991582
People
(Reporter: aknow, Assigned: aknow)
References
Details
Attachments
(1 file)
|
28.59 KB,
patch
|
hsinyi
:
feedback+
|
Details | Diff | Splinter Review |
I am thinking of setting |options.success| automatically in sendChromeMessage() of ril_worker. That means we don't have to explicitly set it to true or false. The value always depends on whether the object contains an |errorMsg|. By this way --
1. All the messages without errorMsg are successful.
2. If the message is not successful, it guarantees that there is an |errorMsg| showing the details.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → szchen
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8473459 -
Flags: feedback?(htsai)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8473459 [details] [diff] [review]
0001-set-options.success-automatically.patch
Review of attachment 8473459 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me!
Attachment #8473459 -
Flags: feedback?(htsai) → feedback+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•