Closed
Bug 1054132
Opened 11 years ago
Closed 11 years ago
[Settings] simplify hour12 detection way
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S2 (15aug)
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
Currently we fake a time to detect if the result is 24hour or 12hour.
There's a simpler way to do so by check if '%p' is exist in ShortTimeFormat string.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8473469 -
Flags: review?(arthur.chen)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8473469 [details] [review]
pull request redirect to github
Per the discussion, we should check %I instead of %p.
Attachment #8473469 -
Flags: review?(arthur.chen)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8473469 [details] [review]
pull request redirect to github
Thanks for address it. PR updated and please kindly review it again.
Attachment #8473469 -
Flags: review?(arthur.chen)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8473469 [details] [review]
pull request redirect to github
LGTM, thanks.
Attachment #8473469 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
merged to gaia master https://github.com/mozilla-b2g/gaia/commit/7a49a7c9449e1a62d0735a04c0a6cf74803e71db
thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•