[Settings] simplify hour12 detection way

RESOLVED FIXED in 2.1 S2 (15aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

unspecified
2.1 S2 (15aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Currently we fake a time to detect if the result is 24hour or 12hour.

There's a simpler way to do so by check if '%p' is exist in ShortTimeFormat string.
(Assignee)

Updated

4 years ago
Assignee: nobody → gasolin
Depends on: 1023735
(Assignee)

Comment 1

4 years ago
Created attachment 8473469 [details] [review]
pull request redirect to github
Attachment #8473469 - Flags: review?(arthur.chen)
Comment on attachment 8473469 [details] [review]
pull request redirect to github

Per the discussion, we should check %I instead of %p.
Attachment #8473469 - Flags: review?(arthur.chen)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8473469 [details] [review]
pull request redirect to github

Thanks for address it. PR updated and please kindly review it again.
Attachment #8473469 - Flags: review?(arthur.chen)
Comment on attachment 8473469 [details] [review]
pull request redirect to github

LGTM, thanks.
Attachment #8473469 - Flags: review?(arthur.chen) → review+
(Assignee)

Comment 5

4 years ago
merged to gaia master https://github.com/mozilla-b2g/gaia/commit/7a49a7c9449e1a62d0735a04c0a6cf74803e71db

thanks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in before you can comment on or make changes to this bug.