1054185 - "Default" is missing from SIM picker

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

### STR
1. DSDS phone with 2 SIMs, and default is set in "Settings" -> "Sim manager"
2. Have a number in call log.
3. Long tap on that number in call log.
4. Choose "Send Message".
5. Type something and long tap the "Send" button to bring up the "Select SIM" page.

### Actual
v2.1-Messages-SelectSIM_fromCalllog.png
"SIM1", "SIM2" Shown.

### Expected
"SIM1 (default)", "SIM2" Shown.

### Version
Gaia      c7f8938522a18454809fb6ea0fd3eddef10a73ea
Gecko     https://hg.mozilla.org/mozilla-central/rev/9eb591a1a203
BuildID   20140814160206
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

https://www.youtube.com/watch?v=nM9-bBMbhDg&index=1

Hi Julien, Could you help with this, also we need to change "SIM1" to "SIM 1" right, I will file another bug for that, thanks.

Comment 2

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]:
1. Regression.
2. Label missing causes confusion of default.

Comment 3

[Julien Wajsberg [:julienw]]

Interesting one.

Eric, does it still work as expected when using the "send sms" button in the Contacts app? If yes, then it's not a regression since the "longpress" menu in the call log is new in v2.1.

Comment 4

[Eric Chang [:ericcc] [:echang]]

When using the "send sms" button in the Contacts app, it still shows 'SIM 1', 'SIM 2', no trailing 'default' after any of each. It has 'default' in v2.0.

Comment 5

[Julien Wajsberg [:julienw]]

Thanks, then using the Contacts app is a better STR to find the regression window, because the STR using the call log might lead to the commit implementing the menu for the call log.

QA, please use STR in comment 3 to find the regression window.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

I found that this issue only reproduces on the 1st attempt. All subsequent attempts will successfully bring up the SIM selection menu with a '(default)' labeled. To repro the bug again the user will have to kill the app and launch it again.

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140721120230
Gaia: 265bcc8bd54f9da013ff67e1f5826ccfb84df1de
Gecko: 31e1810ef190
Version: 33.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken Environmental Variables:
Device: Flame
Gaia: 8d13375b488852bf593b0a6dd0ba90ecf4ee5d43
Gecko: d39392d425a3
Version: 33.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken gecko & last working gaia - issue does NOT repro
Gaia: 265bcc8bd54f9da013ff67e1f5826ccfb84df1de
Gecko: d39392d425a3

First broken gaia & last working gecko - issue DOES repro
Gaia: 8d13375b488852bf593b0a6dd0ba90ecf4ee5d43
Gecko: 31e1810ef190

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/265bcc8bd54f9da013ff67e1f5826ccfb84df1de...8d13375b488852bf593b0a6dd0ba90ecf4ee5d43

Caused by Bug 1037637.

Comment 7

[Joshua Mitchell (Inactive)]

Broken by bug 1037637 ?

Comment 8

[Julien Wajsberg [:julienw]]

Eric, actually, I've seen this also when just launching the application.

Comment 9

[Doug Sherk (:drs) (inactive)]

I noticed this as well and it will be fixed accidentally in bug 1045820. I believe that it will land before FC so we could just dupe this to that. But I'll look into this anyways as I'd like to know why exactly it's happening.

Comment 10

[Doug Sherk (:drs) (inactive)]

Attachment: Fix "Default" being missing from SIM picker.

PR: https://github.com/mozilla-b2g/gaia/pull/23042

Comment 11

[Eric Chang [:ericcc] [:echang]]

Yes, just tried that, reproducible...
(In reply to Julien Wajsberg [:julienw] (PTO 08/19 -> 09/15; contact schung for SMS matters) from comment #8)
> Eric, actually, I've seen this also when just launching the application.

Comment 12

[Anthony Ricaud (:rik)]

Comment on attachment 8475300 [details] [diff] [review]
Fix "Default" being missing from SIM picker.

Review of attachment 8475300 [details] [diff] [review]:
-----------------------------------------------------------------

This needs a new test.

Comment 13

[Doug Sherk (:drs) (inactive)]

Attachment: Fix "Default" being missing from SIM picker.

Updated PR. The test "SIM picker buttons should mark default SIM" fails without the changes to sim_picker.js.

Comment 14

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/2b8d7ccb77565440b3edb0f56e91bd1f60a83196

Comment 15

[bhavana bajaj [:bajaj]]

Switching the 2.1?->2.1+, on these fixed bugs as these are regression.

Nothing to land here, its just flag-cleanup of 2.1? list. Please Ni me if there is confusion/disagreement.

Comment 16

[Eric Chang [:ericcc] [:echang]]

Gaia-Rev        b542080231bb9cdbdb282ab926965ad3f91f7460
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03
Build-ID        20140923155123
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  27
FW-Date         Thu Sep  4 14:59:02 CST 2014
Bootloader      L1TC10011800

Comment 17

[Lancy(Leave from Mozilla)]

Attachment: Video_Flame v2.1.MP4

This issue doesn't exist on the Flame v2.1.
Occurrence rate: 0/20
Flame v2.1 version:
Gaia-Rev        afdfa629be209dd53a1b7b6d6c95eab7077ffcd9
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6
Build-ID        20141123001201
Version         34.0