1054320 - [FTU] Update dark themed pages to match new system colors

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Kevin Grandon :kgrandon]

Some of the colors in the web components and system app have changed recently. Let's update the FTU app to algin with these.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey guys - could either of you review this pull request? The current noise behind the dark themed pages do not match up with the new web components/system colors, so they should be updated.

Whoever gets to it first please clear the other review. Thank you as always.

Comment 2

[Fernando Campo (:fcampo)]

Comment on attachment 8473713 [details] [review]
Github pull request

Let's clean my list of reviews with an easy one, and unload Francisco a little :D

Thanks for fixing it that fast Kevin.
Should we link it to the original change of colour for dark theme? is there a meta bug for it?

Comment 3

[Kevin Grandon :kgrandon]

Thanks for the quick review Fernando! I will try to look for the bugs, I think the relevant one would be whichever one implemented the <gaia-buttons> in the FTU app, and I'm not sure which bug that would be, though we can track it down if needed.

Landed in master: https://github.com/mozilla-b2g/gaia/commit/80af230b57220198d213754ba1d82046468d6695

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2976adaf3278

Comment 5

[[e-mail]]

(In reply to Carsten Book from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/2976adaf3278

This is my fault; I typoed the bug# on my checkin. The correct bug for this push is 1053420.