Closed Bug 1054323 Opened 10 years ago Closed 10 years ago

Use correct background selector on tabs panel's menu button

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox32 unaffected, firefox33 verified, firefox34 verified, fennec33+)

Status:
VERIFIED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox32 --- unaffected
firefox33 --- verified
firefox34 --- verified
fennec 33+ ---

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

Use correct background selector on tabs panel's menu button (r=margaret)
1.98 KB, patch
Margaret
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
It's supposed to use the inverse colors.
Attachment #8473711 - Flags: review?(margaret.leibovic)
Good catch!
Blocks: 817716
tracking-fennec: --- → ?
Attachment #8473711 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/695e23d833b6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Needs uplift
tracking-fennec: ? → 33+
status-firefox33: --- → affected
status-firefox34: --- → fixed
Flags: needinfo?(lucasr.at.mozilla)
Comment on attachment 8473711 [details] [diff] [review]
Use correct background selector on tabs panel's menu button (r=margaret)

Approval Request Comment
[Feature/regressing bug #]: bug 817716
[User impact if declined]: Inconsistent UI for pressed states in tabs panel
[Describe test coverage new/current, TBPL]: Local testing, landed in nightly.
[Risks and why]: Low, just changes a layout file to use the correct drawable.
[String/UUID change made/needed]: n/a
Attachment #8473711 - Flags: approval-mozilla-aurora?
Flags: needinfo?(lucasr.at.mozilla)
Attachment #8473711 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
status-firefox33: fixed → verified
status-firefox34: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: