Closed
Bug 1054323
Opened 11 years ago
Closed 11 years ago
Use correct background selector on tabs panel's menu button
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox32 unaffected, firefox33 verified, firefox34 verified, fennec33+)
VERIFIED
FIXED
Firefox 34
| Tracking | Status | |
|---|---|---|
| firefox32 | --- | unaffected |
| firefox33 | --- | verified |
| firefox34 | --- | verified |
| fennec | 33+ | --- |
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
|
1.98 KB,
patch
|
Margaret
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It's supposed to use the inverse colors.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8473711 -
Flags: review?(margaret.leibovic)
|
||
Updated•11 years ago
|
Attachment #8473711 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
|
||
Comment 5•11 years ago
|
||
Needs uplift
tracking-fennec: ? → 33+
status-firefox33:
--- → affected
status-firefox34:
--- → fixed
Flags: needinfo?(lucasr.at.mozilla)
|
|
||
Updated•11 years ago
|
status-firefox32:
--- → unaffected
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8473711 [details] [diff] [review]
Use correct background selector on tabs panel's menu button (r=margaret)
Approval Request Comment
[Feature/regressing bug #]: bug 817716
[User impact if declined]: Inconsistent UI for pressed states in tabs panel
[Describe test coverage new/current, TBPL]: Local testing, landed in nightly.
[Risks and why]: Low, just changes a layout file to use the correct drawable.
[String/UUID change made/needed]: n/a
Attachment #8473711 -
Flags: approval-mozilla-aurora?
Flags: needinfo?(lucasr.at.mozilla)
|
||
Updated•11 years ago
|
Attachment #8473711 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 7•11 years ago
|
||
|
|
||
Updated•11 years ago
|
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•