1054425 - cache2: leak in CacheFileMetadata::WriteMetadata

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Jason Duell]

ASAN testing is showing 8720 byte(s) leaked in 68 allocation(s) during 

00:09:25  WARNING -  TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::net::CacheFileMetadata::WriteMetadata, mozilla::net::CacheFile::WriteMetadataIfNeededLocked, mozilla::net::CacheFile::~CacheFile
00:09:25     INFO -  runtests.py | Application ran for: 0:41:27.008357

Looks like this is the test that fails (note IPDL-looking error):

0:09:21     INFO -  4821 INFO TEST-OK | /tests/dom/base/test/test_writable-replaceable.html | took 231ms
00:09:21     INFO -  4822 INFO ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost

Comment 1

[Jason Duell]

Looks like this happens in test_storage_session_setitem_js.html too.  See mochitest 1 and 2 failures in 

   https://tbpl.mozilla.org/?tree=Try&rev=a1ea7549c4fd

Comment 2

[Jason Duell]

And also test_hiddenPrivateWindow.xul (see "oth" test in ASAN run).

Comment 3

[Michal Novotny [:michal]]

Attachment: fix

https://tbpl.mozilla.org/?tree=Try&rev=4b9f3a1204b0

Comment 4

[Jason Duell]

Comment on attachment 8474199 [details] [diff] [review]
fix

Review of attachment 8474199 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks good.  Pushed a try build with this and Steve's patch for the other bug in bug 1053517.

Comment 5

[Jason Duell]

Try run looks good (at least for this bug, i.e. the ASAN results):

   https://tbpl.mozilla.org/?tree=Try&rev=fe5dcd1b7abb

Comment 6

[Michal Novotny [:michal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3abedc539cd4

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3abedc539cd4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

ASAN runs look good on Aurora/Beta Try pushes. I think is ready for an uplift nomination.

Comment 9

[Jason Duell]

Comment on attachment 8474199 [details] [diff] [review]
fix

Approval Request Comment
[Feature/regressing bug #]: cache2
[User impact if declined]: memory leak
[Describe test coverage new/current, TBPL]:  ASAN test coverage
[Risks and why]: low, fairly simple leak fix.
[String/UUID change made/needed]: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/16c381733bed

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/342c0c26e18d