1054510 - Turn on SSE for image resizing

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Artem Sobolev [:asobolev]]

A couple of years ago High Quality resizing (Lanczos resampling) was introduced (https://bugzilla.mozilla.org/show_bug.cgi?id=486918) to Firefox. It was done via borrowing corresponding code from Google Chrome's skia and Chrome itself. Apparently, by that time Chrome's implementation was suffering from out-of-bound errors in SIMD case (https://code.google.com/p/chromium/issues/detail?id=181072 don't let the title confuse you, it was changed), so SSE support in FF was deliberately turned off since the very beginning. And still remains off.

Apparently, currently Chrome supports SSE for all major OS, so we should be able to turn it on quite cheaply: SSE implementation of all major functions is already in the source tree and (almost) up to date.

Comment 1

[Artem Sobolev [:asobolev]]

Attachment: This patch turns SSE2 on for image resizing

tbpl: https://tbpl.mozilla.org/?tree=Try&rev=b05a968d8a75

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8480711 [details] [diff] [review]
This patch turns SSE2 on for image resizing

Review of attachment 8480711 [details] [diff] [review]:
-----------------------------------------------------------------

This needs to check for SSE2 support at run time otherwise we'll get crashes on machines that don't have it.

i.e. Factory::HasSSE2()

Comment 3

[Artem Sobolev [:asobolev]]

Attachment: Proposed fix v2

Comment 4

[Artem Sobolev [:asobolev]]

Attachment: sse-resizing.patch

https://tbpl.mozilla.org/?tree=Try&rev=efee73c648e5

Comment 5

[Artem Sobolev [:asobolev]]

All tests: https://tbpl.mozilla.org/?tree=Try&rev=7f80198d59df

Comment 6

[Seth Fowler [:seth] [:s2h]]

Alright, everything looks good on try! Thanks so much for working on this, Artem!

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/16c3207fa04c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/16c3207fa04c

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Looking at this again. Where did the 'int begin, int end' arguments come from? I don't see anything like that in the chrome code.