1054517 - Port Mercurial commit message hook tests to .t test

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

We are in the process of converting Mercurial tests in https://hg.mozilla.org/hgcustom/version-control-tools/ to the Mercurial .t test format. Details of that format at http://mercurial.selenic.com/wiki/WritingTests#Writing_a_shell_script_test.

In this mentored bug, you will take the tests for the commit message hook (https://hg.mozilla.org/hgcustom/version-control-tools/file/6f1da8433d97/hghooks/runtests.py#l402) and port them to a .t test.

You can find existing hooks .t tests in https://hg.mozilla.org/hgcustom/version-control-tools/file/6f1da8433d97/hghooks/tests.

An example conversion is https://hg.mozilla.org/hgcustom/version-control-tools/rev/42b4b8f97dfa.

Comment 1

[Gregory Szorc [:gps]]

I finished this on a plane over the weekend. Patches forthcoming.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Port case only rename hook tests to .t tests

Comment 3

[Gregory Szorc [:gps]]

Attachment: Port commit-messages hook tests to .t tests

During the port, it was realized that the testing methodology in
runtests.py was flawed. Since commits were being stacked, the old
testing code only verified that any commit was bad, not necessarily
that the top commit was bad. This revealed that the hook was examining
the full commit message for bug and backout syntax, as opposed to only
the first line. The hook has been updated to make the tests pass.

Comment 4

[Gregory Szorc [:gps]]

Attachment: Port treeclosure hook tests to .t test

Porting to a .t test required a custom Mercurial extension that
intercepts urllib requests. It has been implemented as part of
this patch. It isn't fully functional, but it mimics the old
testing code and it gets the job done.

Comment 5

[Gregory Szorc [:gps]]

Attachment: Port treeclosure-comm-central tests to .t format

Reviewer note: you may want to look at the previous treeclosure patch
to validate some of the approach.

Comment 6

[Gregory Szorc [:gps]]

Attachment: Remove empty hghooks test harness

All tests in hghooks have been converted to .t tests. We can now remove
hghooks/runtests.py and its integration with run-mercurial-tests.py.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8478345 [details] [diff] [review]
Port treeclosure-comm-central tests to .t format

I'm not sure if I can get to this within the next week or 2, but if ed wants to review this in my stead, I am happy to accept his review.

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8478342 [details] [diff] [review]
Port commit-messages hook tests to .t tests

Review of attachment 8478342 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you - this fixes bug 1053177 for me :-)

Comment 9

[Ed Morley [:emorley]]

Comment on attachment 8478346 [details] [diff] [review]
Remove empty hghooks test harness

Review of attachment 8478346 [details] [diff] [review]:
-----------------------------------------------------------------

::: run-mercurial-tests.py
@@ -161,5 @@
> -
> -        # TODO hook up to unittest directly and share TestSuite and TestResult
> -        # with Mercurial.
> -        args = [sys.executable, os.path.join(HERE, 'hghooks', 'runtests.py')]
> -        res2 = subprocess.call(args, cwd=os.path.join(HERE, 'hghooks'), env=env)

This was the last use of subprocess, the import can be removed now.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8478345 [details] [diff] [review]
Port treeclosure-comm-central tests to .t format

Callek deferred review to edmorley.

Comment 12

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/84358290af8a
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c25d0b056d19
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2cff974474b7
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7ca809dc0f15
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6d6cc743a5af

Comment 13

[Gregory Szorc [:gps]]

I removed the subprocess import from run-mercurial-tests.py.

Thanks for the speedy review!

Good riddance to the old tests and the test spam from runtests.py.