1054632 - constructor init list in wrong order in CrashGenerationServer

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Per bug 666646 comment 3 / bug 666646 comment 4, this is code from upstream, and we should perhaps fix this upstream or else the warning will be reintroduced the next time we update the breakpad library.

(Looks like this code is the same upstream as in our tree, so this hasn't already been fixed upstream:
dump_callback_ listed before filter / filter_context in init list:
https://code.google.com/p/google-breakpad/source/browse/trunk/src/client/mac/crash_generation/crash_generation_server.cc#40
...but after them in class definition:
https://code.google.com/p/google-breakpad/source/browse/trunk/src/client/mac/crash_generation/crash_generation_server.h#121
)

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8474084 [details] [diff] [review]
patch

Review of attachment 8474084 [details] [diff] [review]:
-----------------------------------------------------------------

I can land this upstream. Is this just code hygiene or does it give a compiler warning in newer compilers or what?

Comment 4

[(not currently active) Ted Mielczarek]

Landed upstream:
https://code.google.com/p/google-breakpad/source/detail?r=1366

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> I can land this upstream. Is this just code hygiene or does it give a
> compiler warning in newer compilers or what?

It triggers a compiler warning in GCC and clang, for all versions I'm aware of.  Thanks for upstreaming it!

Comment 6

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2412966d91d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f2412966d91d