Closed Bug 1054671 Opened 11 years ago Closed 3 years ago

Make more static things const

Tracking

()

Status:

RESOLVED FIXED

People

(Reporter: sunfish, Assigned: sunfish)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 7 obsolete files)

const-callbacks.patch 11 years ago Dan Gohman [:sunfish] 36.75 KB, patch		Details \| Diff \| Splinter Review
const-dom.patch 11 years ago Dan Gohman [:sunfish] 32.49 KB, patch		Details \| Diff \| Splinter Review
const-observed-prefs.patch 11 years ago Dan Gohman [:sunfish] 12.37 KB, patch		Details \| Diff \| Splinter Review
const-misc.patch 11 years ago Dan Gohman [:sunfish] 18.20 KB, patch		Details \| Diff \| Splinter Review
const-hasdatamatchingflavors.patch 11 years ago Dan Gohman [:sunfish] 12.58 KB, patch		Details \| Diff \| Splinter Review
const-misc.patch 11 years ago Dan Gohman [:sunfish] 18.59 KB, patch		Details \| Diff \| Splinter Review
const-callbacks.patch 11 years ago Dan Gohman [:sunfish] 44.15 KB, patch		Details \| Diff \| Splinter Review
const-dom.patch 11 years ago Dan Gohman [:sunfish] 200.93 KB, patch		Details \| Diff \| Splinter Review
const-observed-prefs.patch 11 years ago Dan Gohman [:sunfish] 12.30 KB, patch		Details \| Diff \| Splinter Review
const-misc.patch 11 years ago Dan Gohman [:sunfish] 134.88 KB, patch		Details \| Diff \| Splinter Review
const-hasdatamatchingflavors.patch 11 years ago Dan Gohman [:sunfish] 12.51 KB, patch		Details \| Diff \| Splinter Review
const-callbacks.patch 11 years ago Dan Gohman [:sunfish] 44.15 KB, patch	ehsan.akhgari : review+	Details \| Diff \| Splinter Review

Dan Gohman [:sunfish]

Assignee

Description

•

11 years ago

Attached patch const-callbacks.patch (obsolete) — Details — Splinter Review

Attached is a series of patches which adds 'const' to various variables declared in static storage, and associated changes. On some platforms, this allows many of these variables to be placed in read-only memory (either regular read-only memory or memory made read-only after runtime relocations are performed).

Dan Gohman [:sunfish]

Assignee

Comment 1

•

11 years ago

Attached patch const-dom.patch (obsolete) — Details — Splinter Review

Dan Gohman [:sunfish]

Assignee

Comment 2

•

11 years ago

Attached patch const-observed-prefs.patch (obsolete) — Details — Splinter Review

Dan Gohman [:sunfish]

Assignee

Comment 3

•

11 years ago

Attached patch const-misc.patch (obsolete) — Details — Splinter Review

Dan Gohman [:sunfish]

Assignee

Comment 4

•

11 years ago

Attached patch const-hasdatamatchingflavors.patch (obsolete) — Details — Splinter Review

Dan Gohman [:sunfish]

Assignee

Comment 5

•

11 years ago

Attached patch const-misc.patch (obsolete) — Details — Splinter Review

Attachment #8474135 - Attachment is obsolete: true

Dan Gohman [:sunfish]

Assignee

Comment 6

•

11 years ago

Attached patch const-callbacks.patch (obsolete) — Details — Splinter Review

Attachment #8474132 - Attachment is obsolete: true

Dan Gohman [:sunfish]

Assignee

Comment 7

•

11 years ago

Attached patch const-dom.patch — Details — Splinter Review

Attachment #8474133 - Attachment is obsolete: true

Dan Gohman [:sunfish]

Assignee

Comment 8

•

11 years ago

Attached patch const-observed-prefs.patch — Details — Splinter Review

Attachment #8474134 - Attachment is obsolete: true

Dan Gohman [:sunfish]

Assignee

Comment 9

•

11 years ago

Attached patch const-misc.patch — Details — Splinter Review

Attachment #8476306 - Attachment is obsolete: true

Dan Gohman [:sunfish]

Assignee

Comment 10

•

11 years ago

Attached patch const-hasdatamatchingflavors.patch — Details — Splinter Review

Attachment #8474136 - Attachment is obsolete: true

Dan Gohman [:sunfish]

Assignee

Comment 11

•

11 years ago

Attached patch const-callbacks.patch — Details — Splinter Review

Function pointers in static storage are happier when they are const :-).

Attachment #8524015 - Attachment is obsolete: true

Attachment #8536078 - Flags: review?(ehsan.akhgari)

Dan Gohman [:sunfish]

Assignee

Updated

•

11 years ago

Whiteboard: [leave open]

(no longer active)

Updated

•

11 years ago

Attachment #8536078 - Flags: review?(ehsan.akhgari) → review+

Dan Gohman [:sunfish]

Assignee

Comment 12

•

11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3a0e3bfaf6

Nigel Babu [:nigelb]

Comment 13

•

11 years ago

I think this has caught a code issue here: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4663687&repo=mozilla-inbound Would you be able to take a look?

(no longer active)

Comment 14

•

11 years ago

Yes, this seems to be the reason: <https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3a0e3bfaf6#l5.13>

Nigel Babu [:nigelb]

Comment 15

•

11 years ago

Backed out for the bustage https://hg.mozilla.org/integration/mozilla-inbound/rev/29ed7a01c815

Carsten Book [:Tomcat]

Comment 16

•

11 years ago

https://hg.mozilla.org/mozilla-central/rev/b7eb1ce0237d

BugBot [:suhaib / :marco/ :calixte]

Comment 17

•

3 years ago

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: sunfish → nobody

Andrew McCreight (out of office until 8/21) [:mccr8]

Comment 18

•

3 years ago

It looks like one of these patches did land, so I'll just close this. Some of the changes in the unlanded patches do seem applicable, so maybe there's something here to do if anybody is interested. As part of the effort to reduce content process memory overhead, the most egregious of these have probably been fixed. I'll move this to XPCOM as that feels a bit more appropriate.

Blocks: memshrink-content

Status: NEW → RESOLVED

Closed: 3 years ago

Component: General → XPCOM

Resolution: --- → FIXED

Whiteboard: [leave open]

Andrew McCreight (out of office until 8/21) [:mccr8]

Updated

•

3 years ago

Assignee: nobody → sunfish

You need to log in before you can comment on or make changes to this bug.