Open Bug 1054671 Opened 5 years ago Updated 5 years ago

Make more static things const

Categories

(Core :: General, enhancement)

enhancement
Not set

Tracking

()

People

(Reporter: sunfish, Assigned: sunfish)

Details

(Whiteboard: [leave open])

Attachments

(5 files, 7 obsolete files)

Attached patch const-callbacks.patch (obsolete) — Splinter Review
Attached is a series of patches which adds 'const' to various variables declared in static storage, and associated changes.

On some platforms, this allows many of these variables to be placed in read-only memory (either regular read-only memory or memory made read-only after runtime relocations are performed).
Attached patch const-dom.patch (obsolete) — Splinter Review
Attached patch const-observed-prefs.patch (obsolete) — Splinter Review
Attached patch const-misc.patch (obsolete) — Splinter Review
Attached patch const-misc.patch (obsolete) — Splinter Review
Attachment #8474135 - Attachment is obsolete: true
Attached patch const-callbacks.patch (obsolete) — Splinter Review
Attachment #8474132 - Attachment is obsolete: true
Attached patch const-dom.patchSplinter Review
Attachment #8474133 - Attachment is obsolete: true
Attachment #8474134 - Attachment is obsolete: true
Attached patch const-misc.patchSplinter Review
Attachment #8476306 - Attachment is obsolete: true
Attachment #8474136 - Attachment is obsolete: true
Function pointers in static storage are happier when they are const :-).
Attachment #8524015 - Attachment is obsolete: true
Attachment #8536078 - Flags: review?(ehsan.akhgari)
Whiteboard: [leave open]
Attachment #8536078 - Flags: review?(ehsan.akhgari) → review+
I think this has caught a code issue here: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4663687&repo=mozilla-inbound

Would you be able to take a look?
You need to log in before you can comment on or make changes to this bug.