Closed Bug 1054712 Opened 6 years ago Closed 6 years ago

Duplicated logic for HiDPI favicon rendering on tabbrowser and search bar

Categories

(Firefox :: General, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 34
Iteration:
34.2

People

(Reporter: rittme, Assigned: rittme)

References

Details

Attachments

(1 file, 1 obsolete file)

The code that makes uses of #-moz-resolution for rendering HiDPI favicons in tabbrowser and search bar is now duplicated and should instead use the helper function from bug 1052174. 

http://mxr.mozilla.org/mozilla-central/source/browser/components/search/content/search.xml?rev=1061661a1119#296

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml?rev=20f9b816ebcd#834
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Status: NEW → ASSIGNED
QA Whiteboard: [qa?]
QA Whiteboard: [qa?] → [qa-]
Comment on attachment 8474366 [details] [diff] [review]
rev 1 - Replaced duplicate code with call to helper function for HiDPI favicons

Review of attachment 8474366 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget the bug number in the bug # in the commit message. Also, it's unclear from the commit message what "the helper function" is.
Attachment #8474366 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/bcf55557a6b4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.