1054712 - Duplicated logic for HiDPI favicon rendering on tabbrowser and search bar

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bernardo Rittmeyer [:rittme]]

The code that makes uses of #-moz-resolution for rendering HiDPI favicons in tabbrowser and search bar is now duplicated and should instead use the helper function from bug 1052174. 

http://mxr.mozilla.org/mozilla-central/source/browser/components/search/content/search.xml?rev=1061661a1119#296

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml?rev=20f9b816ebcd#834

Comment 1

[Bernardo Rittmeyer [:rittme]]

Attachment: rev 1 - Replaced duplicate code with call to helper function for HiDPI favicons

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8474366 [details] [diff] [review]
rev 1 - Replaced duplicate code with call to helper function for HiDPI favicons

Review of attachment 8474366 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget the bug number in the bug # in the commit message. Also, it's unclear from the commit message what "the helper function" is.

Comment 3

[Bernardo Rittmeyer [:rittme]]

Attachment: rev 1 - Replaced duplicate code with call to helper function getImageURLForResolution for HiDPI favicons. r=MattN

Comment 4

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/bcf55557a6b4

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bcf55557a6b4