1054726 - Add crash log formatting to StructuredFormatter

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[James Graham [:jgraham]]

The StructuredFormatter class needs to be updated for crash log handling.

Comment 1

[James Graham [:jgraham]]

Attachment: Add crash log formatting to StructuredFormatter

Comment 2

[James Graham [:jgraham]]

Attachment: Use the TbplFormatter from mozlog to format structured output

More substantive approach in which we replace the mozharness-specific formatter with the one in mozlog. This only works for tests using structured logging; if we want mozharness itself to use structured logging it will be necessary for it to have a copy of mozlog in its tree.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8474208 [details] [diff] [review]
Add crash log formatting to StructuredFormatter

Review of attachment 8474208 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/structuredlog.py
@@ +65,5 @@
> +    def format_crash(self, data):
> +        id = self.id_str(data["test"]) if "test" in data else "pid: " % data["process"]
> +
> +        rv = ["PROCESS-CRASH | %s | application crashed [%s]" % (id,
> +                                                                 data["signature"])]

Is data guaranteed to have 'process' and 'signature' keys?

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8474270 [details] [diff] [review]
Use the TbplFormatter from mozlog to format structured output

Review of attachment 8474270 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/structuredlog.py
@@ +13,3 @@
>  
>  class StructuredOutputParser(OutputParser):
> +    # The scrip class using this must inherit the MozbaseMixin to ensure

s/scrip/script

Comment 5

[James Graham [:jgraham]]

https://hg.mozilla.org/build/mozharness/rev/6f30bb65e223

Comment 6

[Simone Bruno [:simone]]

In production with reconfig on 2014-08-19 10:47 PT