Add crash log formatting to StructuredFormatter

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgraham, Assigned: jgraham)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
The StructuredFormatter class needs to be updated for crash log handling.
(Assignee)

Comment 1

3 years ago
Created attachment 8474208 [details] [diff] [review]
Add crash log formatting to StructuredFormatter
Attachment #8474208 - Flags: review?(jgriffin)
(Assignee)

Updated

3 years ago
Assignee: nobody → james
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8474270 [details] [diff] [review]
Use the TbplFormatter from mozlog to format structured output

More substantive approach in which we replace the mozharness-specific formatter with the one in mozlog. This only works for tests using structured logging; if we want mozharness itself to use structured logging it will be necessary for it to have a copy of mozlog in its tree.
Attachment #8474270 - Flags: review?(jgriffin)
Comment on attachment 8474208 [details] [diff] [review]
Add crash log formatting to StructuredFormatter

Review of attachment 8474208 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/structuredlog.py
@@ +65,5 @@
> +    def format_crash(self, data):
> +        id = self.id_str(data["test"]) if "test" in data else "pid: " % data["process"]
> +
> +        rv = ["PROCESS-CRASH | %s | application crashed [%s]" % (id,
> +                                                                 data["signature"])]

Is data guaranteed to have 'process' and 'signature' keys?
Attachment #8474208 - Flags: review?(jgriffin) → review+
Comment on attachment 8474270 [details] [diff] [review]
Use the TbplFormatter from mozlog to format structured output

Review of attachment 8474270 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/structuredlog.py
@@ +13,3 @@
>  
>  class StructuredOutputParser(OutputParser):
> +    # The scrip class using this must inherit the MozbaseMixin to ensure

s/scrip/script
Attachment #8474270 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/build/mozharness/rev/6f30bb65e223
In production with reconfig on 2014-08-19 10:47 PT
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.