1054824 - [EME] EMEDecryptor has no way of detecting GMP shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

If we're using the CDM/GMP in decrypt-only mode, then if the GMP crashes or shutsdown naturally while we're not decrypting, we won't receive any kind of notification. So if the decode thread is waiting for the MP4Reader to produce output (in the loop in MP4Reader::Decode()) then we won't ever be woken up to break out of the wait, and we'll hang on shutdown.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

If there are outstanding decodes when the CDM shuts down, report then as failed to the EMEDecryptor.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/adde83d45909

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/adde83d45909