1054828 - Improve MediaDecoderStateMachine logging

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

1. Add some debugging logs
2. Add DECODER_WARN to output warning messages which includes decoder pointer to make debugging easier
3. Replace |DECODER_LOG(PR_LOG_WARNING, ...)| with |DECODER_WARN| so that it is easier to see warning messages in debug build without turning on PRLOG.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1054828_MediaDecoderStateMachine_add_logs.patch

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

https://tbpl.mozilla.org/?tree=Try&rev=5aef45a04b3b

It breaks Windows debug build, weird...

I guess have to tweak the macro to make MSVC happy...

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=46320937&tree=Try&full=1#error0

The macro is expanded to
nsPrintfCString("Decoder=%p " "Failed to request video during seek", mDecoder.get(),).get()

I don't understand why the extra comma is not deleted.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1054828_MediaDecoderStateMachine_add_logs-v2.patch

A workaround for the build error in comment 3.
Try: https://tbpl.mozilla.org/?tree=Try&rev=80d42ca1e1cf
All platforms build green.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55c2f8931669

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/55c2f8931669