Closed Bug 1054828 Opened 7 years ago Closed 7 years ago

Improve MediaDecoderStateMachine logging

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file, 1 obsolete file)

1. Add some debugging logs
2. Add DECODER_WARN to output warning messages which includes decoder pointer to make debugging easier
3. Replace |DECODER_LOG(PR_LOG_WARNING, ...)| with |DECODER_WARN| so that it is easier to see warning messages in debug build without turning on PRLOG.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8474335 - Flags: review?(cpearce)
Attachment #8474335 - Flags: review?(cpearce) → review+
https://tbpl.mozilla.org/?tree=Try&rev=5aef45a04b3b

It breaks Windows debug build, weird...

I guess have to tweak the macro to make MSVC happy...
https://tbpl.mozilla.org/php/getParsedLog.php?id=46320937&tree=Try&full=1#error0

The macro is expanded to
nsPrintfCString("Decoder=%p " "Failed to request video during seek", mDecoder.get(),).get()

I don't understand why the extra comma is not deleted.
A workaround for the build error in comment 3.
Try: https://tbpl.mozilla.org/?tree=Try&rev=80d42ca1e1cf
All platforms build green.
Attachment #8474335 - Attachment is obsolete: true
Attachment #8475810 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/55c2f8931669
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.