1054908 - Ensure UDPSocketChild is released on main thread

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

NrSocketIpc is deleted immediately if any error happened during creation [1]. In this case, UDPSocketChild will be release on STS thread and will cause assertion on debug build.

[1] http://dxr.mozilla.org/mozilla-central/source/media/mtransport/nr_socket_prsock.cpp#1147

23:38:17     INFO -   0  libxul.so!mozilla::dom::UDPSocketChildBase::Release() [UDPSocketChild.cpp:6e524ba66945 : 15 + 0x4]
23:38:17     INFO -       r4 = 0x40245080    r5 = 0x4402725c    r6 = 0x45d2f4e0    r7 = 0x444fca80
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fca10    lr = 0x4134d5d7    pc = 0x4134d5da
23:38:17     INFO -      Found by: given as instruction pointer in context
23:38:17     INFO -   1  libxul.so!mozilla::dom::UDPSocketChild::Release() [UDPSocketChild.cpp:6e524ba66945 : 44 + 0x7]
23:38:17     INFO -       r4 = 0x44027240    r5 = 0x45d2f5b4    r6 = 0x45d2f4e0    r7 = 0x444fca80
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fca30    pc = 0x4134d67d
23:38:17     INFO -      Found by: call frame info
23:38:17     INFO -   2  libxul.so!nsCOMPtr<<unnamed>::IPrivateRemoteInputStream>::~nsCOMPtr [nsCOMPtr.h : 527 + 0x5]
23:38:17     INFO -       r4 = 0x45d2f5a8    r5 = 0x45d2f5b4    r6 = 0x45d2f4e0    r7 = 0x444fca80
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fca40    pc = 0x4083e9f7
23:38:17     INFO -      Found by: call frame info
23:38:17     INFO -   3  libxul.so!mozilla::NrSocketIpc::~NrSocketIpc [nr_socket_prsock.h:6e524ba66945 : 221 + 0x17]
23:38:17     INFO -       r4 = 0x45d2f4e0    r5 = 0x45d2f5b4    r6 = 0x45d2f4e0    r7 = 0x444fca80
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fca48    pc = 0x40d1af99
23:38:17     INFO -      Found by: call frame info
23:38:17     INFO -   4  libxul.so!mozilla::NrSocketIpc::~NrSocketIpc [nr_socket_prsock.h:6e524ba66945 : 221 + 0x5]
23:38:17     INFO -       r4 = 0x45d2f4e0    r5 = 0x46002f7c    r6 = 0x45d2f4e0    r7 = 0x444fca80
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fca60    pc = 0x40d1afc1
23:38:17     INFO -      Found by: call frame info
23:38:17     INFO -   5  libxul.so!nr_socket_local_create [nr_socket_prsock.cpp:6e524ba66945 : 1127 + 0x7]
23:38:17     INFO -       r4 = 0x00000003    r5 = 0x46002f7c    r6 = 0x45d2f4e0    r7 = 0x444fca80
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fca68    pc = 0x40d1e24b
23:38:17     INFO -      Found by: call frame info
23:38:17     INFO -   6  libxul.so!nr_ice_component_initialize [ice_component.c:6e524ba66945 : 198 + 0x7]
23:38:17     INFO -       r4 = 0x44bc288c    r5 = 0x461f0b8c    r6 = 0x46002f7c    r7 = 0x46002f7c
23:38:17     INFO -       r8 = 0x42d9f8ec    r9 = 0x444ffd5f   r10 = 0x46002fb4    fp = 0x00000000
23:38:17     INFO -       sp = 0x444fcaa0    pc = 0x41a7e607

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: ensure-socket-child-delete-on-main-thread.patch

Use nsMainThreadPtrHandle to manage the life cycle of UDPSocketChild.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: ensure-socket-child-delete-on-main-thread.patch

rebase to latest m-c, carry r+.

try: https://tbpl.mozilla.org/?tree=Try&rev=b91ca865846c

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

try looks green, ready to land.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec59bdec088

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ec59bdec088