1054979 - Do not show overflow menu for apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

Currently the overflow menu is displayed when an app requests browser chrome. UX would like this to not be shown for apps because it serves little purpose.

Comment 1

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23285

Hi, do either of you have time to review this?

This patch involves adding a new "browser" class to appWindows to indicate whether they are a browser window.

I think this is useful, but if you don't think we should do this then it might be possible to implement this by setting the overflow menu to "disabled" and doing some more complicated CSS rules like those currently used for back & forward button disabled cases.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8478616 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23285

I think I'm fine with this, probably should have Alive's R+ stamp though. Thanks!

Comment 3

[Ben Francis [:benfrancis]]

TBPL fell over, rebasing and pushing again.

Comment 4

[Ben Francis [:benfrancis]]

Let's try one more time.

Comment 5

[Ben Francis [:benfrancis]]

There are three integration test failures which have been isolated to bug 1047143 which will be backed out.

Landed on master https://github.com/mozilla-b2g/gaia/commit/dab8ef63cc0b43a82bb4013c7c982af8cd1bb29e