Closed Bug 1055038 Opened 8 years ago Closed 8 years ago

False positive in test_lockscreen_unlock_to_camera

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: viorela)

Details

Attachments

(2 files)

The step on line 25:
lock_screen.wait_for_lockscreen_not_visible()

Occurs after Marionette switches to the Camera app.

This means the wait will always resolve to True no matter what.

We should refine this step, or have it check the lockscreen is not visible from the System app's context.
Assignee: nobody → viorela.ioia
Attachment #8476629 - Flags: review?(zcampbell)
Attachment #8476629 - Flags: review?(robert.chira)
Attachment #8476629 - Flags: review?(florin.strugariu)
Attachment #8476629 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

r-, I commented that I don't think you need to change the app object, you only need to change that the test waits/checks the correct app is open.
Attachment #8476629 - Flags: review?(zcampbell) → review-
Attachment #8476629 - Flags: review?(robert.chira)
Comment on attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

PR updated
Attachment #8476629 - Flags: review?(zcampbell)
Attachment #8476629 - Flags: review?(florin.strugariu)
Attachment #8476629 - Flags: review-
Attachment #8476629 - Flags: review?(robert.chira)
Attachment #8476629 - Flags: review?(robert.chira) → review+
Attachment #8476629 - Flags: review?(zcampbell)
Attachment #8476629 - Flags: review?(florin.strugariu)
Attachment #8476629 - Flags: review+
Do we need this on v2.1
Flags: needinfo?(robert.chira)
Attached file uplift to v2.1
Attachment #8497444 - Flags: review?(viorela.ioia)
Attachment #8497444 - Flags: review?(florin.strugariu)
Flags: needinfo?(robert.chira)
Comment on attachment 8497444 [details] [review]
uplift to v2.1

https://github.com/mozilla-b2g/gaia/pull/24559
Attachment #8497444 - Flags: review?(viorela.ioia)
Attachment #8497444 - Flags: review?(florin.strugariu)
Attachment #8497444 - Flags: review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.