False positive in test_lockscreen_unlock_to_camera

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: zac, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
The step on line 25:
lock_screen.wait_for_lockscreen_not_visible()

Occurs after Marionette switches to the Camera app.

This means the wait will always resolve to True no matter what.

We should refine this step, or have it check the lockscreen is not visible from the System app's context.
(Assignee)

Updated

3 years ago
Assignee: nobody → viorela.ioia
(Assignee)

Comment 1

3 years ago
Created attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140
Attachment #8476629 - Flags: review?(zcampbell)
Attachment #8476629 - Flags: review?(robert.chira)
Attachment #8476629 - Flags: review?(florin.strugariu)
Attachment #8476629 - Flags: review?(florin.strugariu) → review-
(Reporter)

Comment 2

3 years ago
Comment on attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

r-, I commented that I don't think you need to change the app object, you only need to change that the test waits/checks the correct app is open.
Attachment #8476629 - Flags: review?(zcampbell) → review-
Attachment #8476629 - Flags: review?(robert.chira)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

PR updated
Attachment #8476629 - Flags: review?(zcampbell)
Attachment #8476629 - Flags: review?(florin.strugariu)
Attachment #8476629 - Flags: review-
(Assignee)

Updated

3 years ago
Attachment #8476629 - Flags: review?(robert.chira)
Attachment #8476629 - Flags: review?(robert.chira) → review+
Attachment #8476629 - Flags: review?(zcampbell)
Attachment #8476629 - Flags: review?(florin.strugariu)
Attachment #8476629 - Flags: review+
merged in https://github.com/mozilla-b2g/gaia/commit/30f39bb2a186cee1c5c1aa3a0eb9634ae73f7739
Do we need this on v2.1
Flags: needinfo?(robert.chira)
Created attachment 8497444 [details] [review]
uplift to v2.1
Attachment #8497444 - Flags: review?(viorela.ioia)
Attachment #8497444 - Flags: review?(florin.strugariu)
Flags: needinfo?(robert.chira)
Comment on attachment 8497444 [details] [review]
uplift to v2.1

https://github.com/mozilla-b2g/gaia/pull/24559
Attachment #8497444 - Flags: review?(viorela.ioia)
Attachment #8497444 - Flags: review?(florin.strugariu)
Attachment #8497444 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/8dccacafcd95e923eedf546a74ba9072ff9ad34d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.