1055038 - False positive in test_lockscreen_unlock_to_camera

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

The step on line 25:
lock_screen.wait_for_lockscreen_not_visible()

Occurs after Marionette switches to the Camera app.

This means the wait will always resolve to True no matter what.

We should refine this step, or have it check the lockscreen is not visible from the System app's context.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

Comment 2

[Zac C (:zac)]

Comment on attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

r-, I commented that I don't think you need to change the app object, you only need to change that the test waits/checks the correct app is open.

Comment 3

[Viorela Ioia [:viorela]]

Comment on attachment 8476629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/23140

PR updated

Comment 4

[Florin Strugariu [:Bebe]]

merged in https://github.com/mozilla-b2g/gaia/commit/30f39bb2a186cee1c5c1aa3a0eb9634ae73f7739

Comment 5

[Florin Strugariu [:Bebe]]

Do we need this on v2.1

Comment 6

[Robert Chira [:RobertC]]

Attachment: uplift to v2.1

Comment 7

[Florin Strugariu [:Bebe]]

Comment on attachment 8497444 [details] [review]
uplift to v2.1

https://github.com/mozilla-b2g/gaia/pull/24559

Comment 8

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/8dccacafcd95e923eedf546a74ba9072ff9ad34d