nsHashKey::nsHashKey is an inline candidate

RESOLVED FIXED in mozilla0.9.6

Status

()

defect
P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: dp, Assigned: dp)

Tracking

({perf})

Trunk
mozilla0.9.6
x86
Windows 2000
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

18 years ago
nsHashKey::nsHashKey 72,745 calls on startup
Assignee

Updated

18 years ago
Blocks: 7251
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6

Comment 2

18 years ago
Comment on attachment 55797 [details] [diff] [review]
Inline nsHashKey::nsHashKey

sr=jband
Looks like this compiles to a NOP in release
builds. That would be a space savings too.
We're sure we don't mind compiling this into clients
and precluding changing behavior via a dll upgrade?
Attachment #55797 - Flags: superreview+
Comment on attachment 55797 [details] [diff] [review]
Inline nsHashKey::nsHashKey

looks fine
Attachment #55797 - Flags: review+
Comment on attachment 55797 [details] [diff] [review]
Inline nsHashKey::nsHashKey

looks fine
Assignee

Comment 5

18 years ago
Yes this compiles to a NOP. Currently there is no plan for dll ugrade. The
closest our thought process is to this is xpcom component/module upgrade, I
think. And this doesn't fall into the latter.
Assignee

Comment 6

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.