Closed
Bug 105509
Opened 23 years ago
Closed 23 years ago
nsHashKey::nsHashKey is an inline candidate
Categories
(Core :: XPCOM, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: dp, Assigned: dp)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
1.04 KB,
patch
|
dougt
:
review+
jband_mozilla
:
superreview+
|
Details | Diff | Splinter Review |
nsHashKey::nsHashKey 72,745 calls on startup
|
Assignee | |
Updated•23 years ago
|
|
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
Comment on attachment 55797 [details] [diff] [review]
Inline nsHashKey::nsHashKey
sr=jband
Looks like this compiles to a NOP in release
builds. That would be a space savings too.
We're sure we don't mind compiling this into clients
and precluding changing behavior via a dll upgrade?
Attachment #55797 -
Flags: superreview+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 55797 [details] [diff] [review]
Inline nsHashKey::nsHashKey
looks fine
Attachment #55797 -
Flags: review+
|
|
||
Comment 4•23 years ago
|
||
Comment on attachment 55797 [details] [diff] [review]
Inline nsHashKey::nsHashKey
looks fine
|
|
Assignee | |
Comment 5•23 years ago
|
||
Yes this compiles to a NOP. Currently there is no plan for dll ugrade. The
closest our thought process is to this is xpcom component/module upgrade, I
think. And this doesn't fall into the latter.
|
|
Assignee | |
Comment 6•23 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•