Closed Bug 1055101 Opened 5 years ago Closed 5 years ago
Simple bookmarks migration to homescreen
46 bytes, text/x-github-pull-request
|Details | Review|
Opening this bug to track a 'dumb' bookmarks migration to the homescreen. Nothing fancy, we just: - On upgrade, send a message from FTU to the brower app. - The browser app stores bookmarks in datastore.
This pull request migrates bookmarks during FTU by sending an IAC message to the browser app. The browser is hidden by a role="system" in the manifest. It does unfortunately live-on in the codebase, so it would be good to have some kind of uninstall mechanism for it in the future.
Comment on attachment 8474708 [details] [review] WIP Pull Request - Migrate bookmarks and hide browser icon I would like to open this for a preliminary review. This will only land if we don't have the full solution by Friday, and then we can always back it out before 2.1 branches if we desire. This is a fairly simple migration which does exactly what the homescreen migration does. Flagging a few people from the browser app, and a few people from FTU. Likely only need 1 review per part. Thanks guys!
I have migration into review on bug 938171 now. My method should allow us to completely do away with the browser app, so I'd prefer to go that direction, but I'm happy keeping this around just in case we find something wrong and need to switch fast.
Comment on attachment 8474708 [details] [review] WIP Pull Request - Migrate bookmarks and hide browser icon (In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #4) > I have migration into review on bug 938171 now. My method should allow us to > completely do away with the browser app, so I'd prefer to go that direction, > but I'm happy keeping this around just in case we find something wrong and > need to switch fast. Sounds good Kyle. I only opened this up because at the time it seemed like bookmarks might not make it. If you're confident that approach will work well for 2.1, let's go with that. Clearing reviews for now, and will close this once the other bug lands.
No longer blocks: 945827
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.