1055166 - Flash doesn't work on Android L

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Flash plugin loads but crashes when you try to use it on Android L. I get the following Java exception:

E/GeckoAppShell(  983): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1770 ("Gecko")
E/GeckoAppShell(  983): java.lang.IllegalStateException: This message cannot be recycled because it is still in use.
E/GeckoAppShell(  983): 	at android.os.Message.recycle(Message.java:261)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.GeckoAppShell.pumpMessageLoop(GeckoAppShell.java:2473)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Important, but not as important as other Android L breakage (like video)

Comment 2

[Aaron Train [:aaronmt]]

For the 1%

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

I have added this to the notes for Firefox 32-34.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Indication here is that this is a bug in Android and will be fixed: https://code.google.com/p/android-test-kit/issues/detail?id=84

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Wait, I maybe they fixed the testing stuff instead of Android. Ugh.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

AFAICT there is nothing no reasonable way to check if it's in use or not, and no notification of that changing. I think we want to just catch and eat the exception here.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Catch IllegalStateException when recycling Message

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8480819 [details] [diff] [review]
Catch IllegalStateException when recycling Message

Review of attachment 8480819 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +2478,2 @@
>              // Our "queue is empty" message; see runGecko()
>              msg.recycle();

Is this affected?

@@ +2486,5 @@
> +
> +        try {
> +            msg.recycle();
> +        } catch (IllegalStateException e) {
> +            // There is nothing we can do here so just eat it

Maybe add simple explanation/bug number?

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Jim Chen [:jchen :nchen] from comment #8)
> Comment on attachment 8480819 [details] [diff] [review]
> Catch IllegalStateException when recycling Message
> 
> Review of attachment 8480819 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/GeckoAppShell.java
> @@ +2478,2 @@
> >              // Our "queue is empty" message; see runGecko()
> >              msg.recycle();
> 
> Is this affected?

It doesn't appear to be, I think because it's never dispatched to a Handler.

> 
> @@ +2486,5 @@
> > +
> > +        try {
> > +            msg.recycle();
> > +        } catch (IllegalStateException e) {
> > +            // There is nothing we can do here so just eat it
> 
> Maybe add simple explanation/bug number?

Yup, adding that.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/181168ddad52

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/181168ddad52