Flash doesn't work on Android L

RESOLVED FIXED in Firefox 34

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: snorp, Assigned: snorp)

Tracking

(Blocks 1 bug)

unspecified
Firefox 34
All
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox31 affected, firefox32 affected, firefox33 affected, firefox34 affected, firefox-esr24 affected, firefox-esr31 affected, relnote-firefox 32+, fennec+)

Details

Attachments

(1 attachment)

Flash plugin loads but crashes when you try to use it on Android L. I get the following Java exception:

E/GeckoAppShell(  983): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1770 ("Gecko")
E/GeckoAppShell(  983): java.lang.IllegalStateException: This message cannot be recycled because it is still in use.
E/GeckoAppShell(  983): 	at android.os.Message.recycle(Message.java:261)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.GeckoAppShell.pumpMessageLoop(GeckoAppShell.java:2473)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360)
E/GeckoAppShell(  983): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)
Blocks: android-l
Severity: normal → enhancement
Important, but not as important as other Android L breakage (like video)
tracking-fennec: ? → +
Severity: enhancement → normal
For the 1%
relnote-firefox: --- → ?
I have added this to the notes for Firefox 32-34.
Indication here is that this is a bug in Android and will be fixed: https://code.google.com/p/android-test-kit/issues/detail?id=84
Wait, I maybe they fixed the testing stuff instead of Android. Ugh.
AFAICT there is nothing no reasonable way to check if it's in use or not, and no notification of that changing. I think we want to just catch and eat the exception here.
Attachment #8480819 - Attachment description: recycle.diff → Catch IllegalStateException when recycling Message
Comment on attachment 8480819 [details] [diff] [review]
Catch IllegalStateException when recycling Message

Review of attachment 8480819 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +2478,2 @@
>              // Our "queue is empty" message; see runGecko()
>              msg.recycle();

Is this affected?

@@ +2486,5 @@
> +
> +        try {
> +            msg.recycle();
> +        } catch (IllegalStateException e) {
> +            // There is nothing we can do here so just eat it

Maybe add simple explanation/bug number?
Attachment #8480819 - Flags: review?(nchen) → review+
(In reply to Jim Chen [:jchen :nchen] from comment #8)
> Comment on attachment 8480819 [details] [diff] [review]
> Catch IllegalStateException when recycling Message
> 
> Review of attachment 8480819 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/GeckoAppShell.java
> @@ +2478,2 @@
> >              // Our "queue is empty" message; see runGecko()
> >              msg.recycle();
> 
> Is this affected?

It doesn't appear to be, I think because it's never dispatched to a Handler.

> 
> @@ +2486,5 @@
> > +
> > +        try {
> > +            msg.recycle();
> > +        } catch (IllegalStateException e) {
> > +            // There is nothing we can do here so just eat it
> 
> Maybe add simple explanation/bug number?

Yup, adding that.
https://hg.mozilla.org/mozilla-central/rev/181168ddad52
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.