1055212 - JavaScript Error: "this._items[aData] is undefined" {file: "resource://gre/modules/PageActions.jsm" line: 57}]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

[JavaScript Error: "this._items[aData] is undefined" {file: "resource://gre/modules/PageActions.jsm" line: 57}]

In the overflow menu in Nightly in the URL-bar, tapping 'Subscribe to Page' yields the above error.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Ahh. Interesting little fact. Components.utils.import and the nsIJSSubScriptLoader don't use the same cache, so they were generating two different PageActions objects. Margaret's uses the old API, so it was getting a different one than the reader page action uses. Both received the nsIObserverService notifications though. When they saw an id that was registered with the opposite one, they complained.

This uses Component.utils.import in both places.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8477661 [details] [diff] [review]
Patch

Review of attachment 8477661 [details] [diff] [review]:
-----------------------------------------------------------------

Tricky! Good catch.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8477661 [details] [diff] [review]
Patch

Wow! Very tricky. I would have never guessed at this fix. Well done.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/71315eef503a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71315eef503a