Closed Bug 1055212 Opened 5 years ago Closed 5 years ago

JavaScript Error: "this._items[aData] is undefined" {file: "resource://gre/modules/PageActions.jsm" line: 57}]

Categories

(Firefox for Android :: General, defect)

34 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 34
Tracking Status
fennec 34+ ---

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

(Keywords: regression)

Attachments

(1 file)

[JavaScript Error: "this._items[aData] is undefined" {file: "resource://gre/modules/PageActions.jsm" line: 57}]

In the overflow menu in Nightly in the URL-bar, tapping 'Subscribe to Page' yields the above error.
tracking-fennec: --- → ?
Keywords: regression
Assignee: nobody → wjohnston
tracking-fennec: ? → 34+
Attached patch PatchSplinter Review
Ahh. Interesting little fact. Components.utils.import and the nsIJSSubScriptLoader don't use the same cache, so they were generating two different PageActions objects. Margaret's uses the old API, so it was getting a different one than the reader page action uses. Both received the nsIObserverService notifications though. When they saw an id that was registered with the opposite one, they complained.

This uses Component.utils.import in both places.
Attachment #8477661 - Flags: review?(margaret.leibovic)
Comment on attachment 8477661 [details] [diff] [review]
Patch

Review of attachment 8477661 [details] [diff] [review]:
-----------------------------------------------------------------

Tricky! Good catch.
Attachment #8477661 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8477661 [details] [diff] [review]
Patch

Wow! Very tricky. I would have never guessed at this fix. Well done.
https://hg.mozilla.org/mozilla-central/rev/71315eef503a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.