Move CountingAllocatorBase out of nsIMemoryReporter.idl

RESOLVED FIXED in mozilla34

Status

()

Core
XPCOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This seems like it should have its own header file.
(Assignee)

Updated

4 years ago
Assignee: nobody → continuation
(Assignee)

Comment 1

4 years ago
Created attachment 8477496 [details] [diff] [review]
Move CountingAllocatorBase into its own header file.

https://tbpl.mozilla.org/?tree=Try&rev=bed55f58d974
(Assignee)

Updated

4 years ago
Attachment #8477496 - Flags: review?(nfroyd)
Attachment #8477496 - Flags: review?(nfroyd) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Hey Andrew,

this patch failed to apply:

applying Bug-1055280---Move-CountingAllocatorBase-into-its-.patch
patching file xpcom/base/moz.build
Hunk #1 FAILED at 66
1 out of 1 hunks FAILED -- saving rejects to file xpcom/base/moz.build.rej
patch failed, unable to continue (try -v)

could you rebase this patch? Thanks!
Keywords: checkin-needed
(Assignee)

Comment 3

4 years ago
Hopefully that L32 try build actually tested non-unified stuff.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5a6399121f1
https://hg.mozilla.org/mozilla-central/rev/d5a6399121f1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.