1055324 - [B2G][OTA][1.3 -> 2.0] E.Me apps on the homescreen do not keep their icon placement when updating from 1.3 -> 2.0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-OTA.txt

Description:
When performing an OTA from 1.3 to 2.0, any e.me apps (and bookmarks) on the homescreen are moved to their own, separate icon group at the very top of the homescreen after the update, regardless of where they were placed on the homescreen in 1.3.  They appear above the Dialer, Messenger, Contacts, and Browser icon group.


Repro Steps:
1) Base a Flame device to 1.3, v123, then push the latest production gaia
2) Change the OTA update channel and URL to point to 2.0 nightly-b2g32
3) Add several e.me apps to the homescreen on several different pages.
4) Download and apply the OTA.


Actual:
e.me apps are in their own icon group (page) at the top of the screen after the update.


Expected:
e.me apps are in the same icon groups (pages) that they were in before the update.

This occurs on both 319MB and 512MB memory.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140818000201
Gaia: fb2dd31abed2803eb7ad67eb4c52abb48de1e0f7
Gecko: 09f7a7184c71
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Keywords: OTA, e.me, Homescreen, Icon, 1.3, 2.0


Repro frequency: 100%
See attached: screenshots, logcat

--------------------------------------------------

This issue does NOT occur on Flame 2.1 at either 319MB or 512MB memory.
E.Me icon placement is preserved after a 2.0 -> 2.1 OTA

Environmental Variables:
Device: Flame Master
Build ID: 20140818040201
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 0aaa2d3d15cc
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 1

[Martin Shuman [:Marty]]

Attachment: 1-3_Screenshot.png

Comment 2

[Martin Shuman [:Marty]]

Attachment: 2-0_Screenshot.png

Comment 3

[Peter Bylenga [:PBylenga]]

qawanted to check 1.3 to 2.1 to see if it's a 1.x to a 2.x which would mean 2.1 is affected as well.

The placement of these icons was maintained previously, calling it a regression.

NI on Johan to determine blocking nomination as he's the qa lead for Homescreen.

Comment 4

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: As per attachment 8464073 [details], this is a regression.

After discussing with :jsavory, each panel in 1.3 should be a group in 2.0. The dock should be the first group in 2.0.

Comment 5

[Jason Smith [:jsmith]]

Peter - Is this a blocker from your product perspective?

Comment 6

[Peter Dolanjski [:pdol]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Peter - Is this a blocker from your product perspective?

Yes.  We could probably live with them being placed lower on the screen, but given that they take priority over former dock icons, I think it's blocking.

Comment 7

[Kevin Grandon :kgrandon]

Cristian, do you think this is the same type of issue as bug 1047276?

Comment 8

[Cristian Rodriguez (:crdlc)]

Hi Kevin,

   I don't think so unfortunately :) Carmen is PTO so I gonna try to take a look here with Albert

(In reply to Kevin Grandon :kgrandon from comment #7)
> Cristian, do you think this is the same type of issue as bug 1047276?

Comment 9

[Cristian Rodriguez (:crdlc)]

Assigned to me while I am working on it

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8475830 [details]
Github pull request

Nice find. Thank you Cristian!

Comment 12

[Johan Lorenzo [:jlorenzo]]

Removing QA wanted, a fix is on its way.

Comment 13

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/e4c122f97355551a8ae95cdd909e051d1a3ff2f7

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/ed257456c512c3b345f5a89e9211581e7ae0f1c0