1055408 - [EME] Kill GMP timers when entering shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We need to cancel the GMPTimers when we start to shutdown a GMP process, otherwise the timers can fire after the IPC bridge has shutdown, and if a timer fires and tries to notify the GMP process Bad Things will happen.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

This is based on top of my patch for bug 1034368 (GMPStorage).

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8474963 [details] [diff] [review]
Patch

Review of attachment 8474963 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/GMPParent.cpp
@@ +246,5 @@
>      mAudioDecoders[i - 1]->Shutdown();
>    }
>  
> +  // Note: we don't shutdown timers here, we do that in CloseIfUnused(),
> +  // as there is multiple entry points to CloseIfUnused().

there are

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b0d1e17cad0

Comment 4

[Nigel Babu [:nigelb]]

Backed out this and the parent patch (I can't see the bug) for bustage.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1db9d4b9d740
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc129c1aef4

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Re-landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/198c0704bacc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/198c0704bacc