[EME] Kill GMP timers when entering shutdown

RESOLVED FIXED in mozilla34

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

29 Branch
mozilla34
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We need to cancel the GMPTimers when we start to shutdown a GMP process, otherwise the timers can fire after the IPC bridge has shutdown, and if a timer fires and tries to notify the GMP process Bad Things will happen.
(Assignee)

Comment 1

4 years ago
Created attachment 8474963 [details] [diff] [review]
Patch

This is based on top of my patch for bug 1034368 (GMPStorage).
Attachment #8474963 - Flags: review?(rjesup)
Comment on attachment 8474963 [details] [diff] [review]
Patch

Review of attachment 8474963 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/GMPParent.cpp
@@ +246,5 @@
>      mAudioDecoders[i - 1]->Shutdown();
>    }
>  
> +  // Note: we don't shutdown timers here, we do that in CloseIfUnused(),
> +  // as there is multiple entry points to CloseIfUnused().

there are
Attachment #8474963 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/198c0704bacc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.