1055467 - Rename MozNamedAttrMap to NamedNodeMap

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

It's not really worth renaming this I think. Let's embrace the web.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: named.patch

https://tbpl.mozilla.org/?tree=Try&rev=b227b2eba9df

Comment 2

[Anne (:annevk)]

Comment on attachment 8475203 [details] [diff] [review]
named.patch

The new name should be NamedNodeMap, not NamedAttrMap.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: named.patch

https://tbpl.mozilla.org/?tree=Try&rev=e2c0780e8214

This patch keeps nsIDOMMozNamedAttrMap but without any methods and attributes just to be compatible with existing addons. I marked this interface builtinclass.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Name NamedNodeMap of course doesn't make any sense, but since DOM 3 Core had that (for Nodes, not only for Attrs), I guess this is fine.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8475275 [details] [diff] [review]
named.patch

Since we have even internal usage for the .idl interface, I wouldn't remove it.
The casting is ugly and error prone.

Why not just rename the webidl interface?

Comment 6

[Andrea Marchesini [:baku]]

Attachment: named.patch

https://tbpl.mozilla.org/?tree=Try&rev=ab4d8237fbd3

Ok, I just tried to remove a idl interface with this patch. But it can be done in a different patch.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8476607 [details] [diff] [review]
named.patch

>-/**
>- * This is a temporary, non-standard interface, to ease the transition to a
>- * world where Attr no longer inherits from Node.
>- */
>-
I don't see reason for this change.

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e528ecd25c9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4e528ecd25c9

Comment 10

[Jean-Yves Perrier [:teoli]]

Updated doc:
https://developer.mozilla.org/en-US/Firefox/Releases/34
https://developer.mozilla.org/en-US/docs/Web/API/NamedNodeMap
https://developer.mozilla.org/en-US/docs/Web/API/Element.attributes