1055473 - {WeakSet, WeakMap}.prototype should be an ordinary object

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Tom S [:evilpie]]

WeakSet.prototype is just an ordinary object.

Comment 1

[Tom S [:evilpie]]

Attachment: plain-proto

Comment 2

[Tom S [:evilpie]]

Apparently there are some tests in dom/ for weakmaps?! https://treeherder.mozilla.org/#/jobs?repo=try&revision=d92ca6857564 The test is not wrong, but we don't yet have WeakMap.prototype.@@toStringTag.

Comment 3

[André Bargull [:anba]]

Dup of bug 656828, except:
- 656828 also changes Map and Debugger
- patches in 656828 are most likely out of date.

Comment 4

[Tom S [:evilpie]]

Attachment: Make WeakMap/Set.prototype a plain object

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 8600686 [details] [diff] [review]
Make WeakMap/Set.prototype a plain object

Review of attachment 8600686 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/imptests/failures/html/js/builtins/test_WeakMap.prototype-properties.html.json
@@ +3,5 @@
>    "WeakMap.prototype.delete.length": true,
>    "WeakMap.prototype.get.length": true,
>    "WeakMap.prototype.has.length": true,
> +  "WeakMap.prototype.set.length": true,
> +  "WeakMap.prototype.@@toStringTag": true

...it's really necessary to *opt IN* to every test you want to run, and not to opt *out* of every test you fail?  Sadfaces.

Comment 6

[Tom S [:evilpie]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #5)
> Comment on attachment 8600686 [details] [diff] [review]
> Make WeakMap/Set.prototype a plain object
> 
> Review of attachment 8600686 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> :::
> dom/imptests/failures/html/js/builtins/test_WeakMap.prototype-properties.
> html.json
> @@ +3,5 @@
> >    "WeakMap.prototype.delete.length": true,
> >    "WeakMap.prototype.get.length": true,
> >    "WeakMap.prototype.has.length": true,
> > +  "WeakMap.prototype.set.length": true,
> > +  "WeakMap.prototype.@@toStringTag": true
> 
> ...it's really necessary to *opt IN* to every test you want to run, and not
> to opt *out* of every test you fail?  Sadfaces.
Well actually that's all the tests that are known to fail. I think all of the "length" tests fail, because we changed the property to be configurable. @@toStringTag fails now, because Object.toString.call(WeakMap.prototype) would return "[object WeakMap] if we had @@toStringTag.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0536b35fa2fa

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/352218aee262

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0536b35fa2fa
https://hg.mozilla.org/mozilla-central/rev/352218aee262

Comment 10

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/Firefox/Releases/40
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap/prototype
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakSet/prototype