1055485 - Casting icon should be top page action

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Karen Rudnitski [:kar]]

The URL bar can only display so many 'action' icons (ie reading list, send to, add-ons, etc). However, to aid in the discovery of 'send to', I would like to propose that the 'send to' action gets top billing when Firefox detects a castable device in the area to help discovery (especially since the 'send to' icon can be hard to find in the video controls).

I haven't fully thought this through, but on the surface, thinks it's a good idea.

Comment 1

[Karen Rudnitski [:kar]]

(especially in light of https://bugzilla.mozilla.org/show_bug.cgi?id=1054915#c3

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

This should be possible with the current code. "Reader" is currently given top priority, but we can give "Send to" the same priority, which should make it #1.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> This should be possible with the current code. "Reader" is currently given
> top priority, but we can give "Send to" the same priority, which should make
> it #1.

Sounds like a good start to me. Are there any issues with say, webpages that are articles but have inline videos (like an interview)?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Anthony Lam (:antlam) from comment #3)
> (In reply to Mark Finkle (:mfinkle) from comment #2)
> > This should be possible with the current code. "Reader" is currently given
> > top priority, but we can give "Send to" the same priority, which should make
> > it #1.
> 
> Sounds like a good start to me. Are there any issues with say, webpages that
> are articles but have inline videos (like an interview)?

Seems like an edge case. Not going to worry about it too much right now.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

After reviewing the code, we are doing what I thought we needed to do: set "important: true"

I don't know what else we'd want to do here.

Hopefully, this won't be a common issue. The "reader" and "send to device" are the only "important" actions we currently have.