1055500 - KeyError: 'subtest' from "and "Test timed out" in message['subtest']):" in dumpScreenOnTimeout runtests.py:1989

Status: RESOLVED INCOMPLETE

(Testing :: Mochitest, defect)

Description

[Ed Morley [:emorley]]

Believe regression from bug 1050251.

Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-devtools-chrome-2 on 2014-08-19 00:32:35 PDT for push a38daccaa557
https://tbpl.mozilla.org/php/getParsedLog.php?id=46241710&tree=Mozilla-Inbound

00:37:58     INFO -  Exception in thread Thread-12:
00:37:58     INFO -  Traceback (most recent call last):
00:37:58     INFO -    File "/tools/python27/lib/python2.7/threading.py", line 551, in __bootstrap_inner
00:37:58     INFO -      self.run()
00:37:58     INFO -    File "/tools/python27/lib/python2.7/threading.py", line 504, in run
00:37:58     INFO -      self.__target(*self.__args, **self.__kwargs)
00:37:58     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 775, in _processOutput
00:37:58     INFO -      self.processOutputLine(line.rstrip())
00:37:58     INFO -    File "/builds/slave/talos-slave/test/build/venv/lib/python2.7/site-packages/mozprocess/processhandler.py", line 720, in processOutputLine
00:37:58     INFO -      handler(line)
00:37:58     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtests.py", line 1860, in processOutputLine
00:37:58     INFO -      message = handler(message)
00:37:58     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtests.py", line 1989, in dumpScreenOnTimeout
00:37:58     INFO -      and "Test timed out" in message['subtest']):
00:37:58     INFO -  KeyError: 'subtest'

Comment 1

[Ahmed Kachkach [:akachkach]]

Ouch, this also triggers on test_end. Will post a patch in a bit.

Comment 2

[Ahmed Kachkach [:akachkach]]

Actually, we already check that the message is a test_status in the previous line.
I think this might be caused by bug 1052937 (some tests do not give assertions a name, so the undefined field is dropped when serializing to JSON).

Comment 3

[Jim Mathies [:jimm]]

I keep hitting this in local mochitest-browser runs on Win7, thought it was my test! I can help test if needed. Just ni me.

Comment 4

[Ed Morley [:emorley]]

Mass-closing old bugs I filed that have not had recent activity/no longer affect me.