Closed
Bug 1055514
Opened 11 years ago
Closed 7 years ago
Reduce overpaint when there is an activity covering the current app
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
etienne
:
review+
|
Details | Diff | Splinter Review |
This is not the prettiest thing but the transition could be refined later. Let's get some fps.
Attachment #8475133 -
Flags: review?(etienne)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8475133 [details] [diff] [review]
less.overpaint.activity.patch
Review of attachment 8475133 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the comments addressed and 2 small tests:
Can you add an assertion here [1] to check that we remove the class, and add one test in |activity_window_test.js| to check that we add it properly.
(yeah I know :/)
[1] https://github.com/mozilla-b2g/gaia/blob/05768c07b9f0fd5f54005e409eeb953f74158d36/apps/system/test/unit/app_window_test.js#L1281
::: apps/system/js/app_window.js
@@ +1771,5 @@
> this.frontWindow.kill();
> }
> this.frontWindow = frontWindow;
> +
> + this.element.classList.add('front-window', !!frontWindow);
can frontWindow be null? did you mean |.toggle(|?
Attachment #8475133 -
Flags: review?(etienne) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•11 years ago
|
||
Not sure why it broke some music tests. Reverting for now: https://github.com/mozilla-b2g/gaia/commit/b2a09ff5f579dd047a434bf67a352490396c20e8
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 4•7 years ago
|
||
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 11 years ago → 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•