1055514 - Reduce overpaint when there is an activity covering the current app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: less.overpaint.activity.patch

This is not the prettiest thing but the transition could be refined later. Let's get some fps.

Comment 1

[Etienne Segonzac (:etienne)]

Comment on attachment 8475133 [details] [diff] [review]
less.overpaint.activity.patch

Review of attachment 8475133 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comments addressed and 2 small tests:

Can you add an assertion here [1] to check that we remove the class, and add one test in |activity_window_test.js| to check that we add it properly.
(yeah I know :/)

[1] https://github.com/mozilla-b2g/gaia/blob/05768c07b9f0fd5f54005e409eeb953f74158d36/apps/system/test/unit/app_window_test.js#L1281

::: apps/system/js/app_window.js
@@ +1771,5 @@
>        this.frontWindow.kill();
>      }
>      this.frontWindow = frontWindow;
> +
> +    this.element.classList.add('front-window', !!frontWindow);

can frontWindow be null? did you mean |.toggle(|?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/21876ef6754a28b3bfebb954ffc11469dc4f66f6

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Not sure why it broke some music tests. Reverting for now: https://github.com/mozilla-b2g/gaia/commit/b2a09ff5f579dd047a434bf67a352490396c20e8

Comment 4

[BMO Automation]

Firefox OS is not being worked on