Add command line options to web-platform-tests for crash reporting.

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgraham, Assigned: jgraham)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

3 years ago
These are currently missing, so we don't get stack traces.
(Assignee)

Comment 1

3 years ago
Created attachment 8475233 [details] [diff] [review]
Add crash reporting settings to web-platform-tests
Attachment #8475233 - Flags: review?(jgriffin)
(Assignee)

Updated

3 years ago
Assignee: nobody → james
Status: NEW → ASSIGNED
Comment on attachment 8475233 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Review of attachment 8475233 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/web_platform_tests.py
@@ +120,5 @@
> +                self.fatal("self.installer_url was not found in self.config")
> +            self.info("setting symbols_url as %s" % (symbols_url))
> +            self._symbols_path = symbols_url
> +
> +        return self._symbols_path

Can we just call http://hg.mozilla.org/build/mozharness/file/63ab82be25bc/mozharness/mozilla/testing/testbase.py#l116 instead?
(Assignee)

Comment 3

3 years ago
Created attachment 8475546 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Apparently we can (desktop_unittest.py probably should too...)
Attachment #8475546 - Flags: review?(jgriffin)
(Assignee)

Updated

3 years ago
Attachment #8475233 - Attachment is obsolete: true
Attachment #8475233 - Flags: review?(jgriffin)
Comment on attachment 8475546 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Review of attachment 8475546 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8475546 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/build/mozharness/rev/6950bcd5c54b
Comment on attachment 8475546 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Merged to production: https://hg.mozilla.org/build/mozharness/rev/7771c9623c92
Attachment #8475546 - Flags: checked-in+
(Assignee)

Comment 7

3 years ago
Created attachment 8475836 [details] [diff] [review]
Fix crash reporting for web-platform-tests

So the previous patch had the minor problem that it didn't actually
work because the stackwalk binary location wasn't set. This patch
assumes that will be set in the in-tree config and passed as a command
line option to wptrunner.
Attachment #8475836 - Flags: review?(jgriffin)
(Assignee)

Updated

3 years ago
Attachment #8475836 - Flags: review?(ahalberstadt)
Comment on attachment 8475836 [details] [diff] [review]
Fix crash reporting for web-platform-tests

Review of attachment 8475836 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with one nit.

::: scripts/web_platform_tests.py
@@ +152,5 @@
>  
>          parser = StructuredOutputParser(config=self.config,
>                                          log_obj=self.log_obj)
>  
> +        env = {'MINIDUMP_SAVE_PATH': self.query_abs_dirs()['abs_blob_upload_dir']}

nit: the 'dirs' variable already stores the result of query_abs_dirs.
Attachment #8475836 - Flags: review?(jgriffin)
Attachment #8475836 - Flags: review?(ahalberstadt)
Attachment #8475836 - Flags: review+
(Assignee)

Comment 9

3 years ago
https://hg.mozilla.org/build/mozharness/rev/f3c0437d982d
In production with reconfig on 2014-08-20 07:47 PT
(Assignee)

Comment 11

3 years ago
Created attachment 8476595 [details] [diff] [review]
Make sure that stackwalk binary is installed when running web-platform-tests

So the previous attachment didn't actually cause the stackwalk binary to be installed. I assumed this was part of the base install on test slaves because I didn't see any code in desktop_unittests to deal with it (and I still don't so I am somewhat confused about why that works...). It turns out that TestingMixin already has code to do this, however and by invoking that I can get stack dumps when running this on my loal machine. So I am moderately convinced that this will actually work.
Attachment #8476595 - Flags: review?(ahalberstadt)
(Assignee)

Updated

3 years ago
Attachment #8475836 - Attachment is obsolete: true
Comment on attachment 8476595 [details] [diff] [review]
Make sure that stackwalk binary is installed when running web-platform-tests

Review of attachment 8476595 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8476595 - Flags: review?(ahalberstadt) → review+
(Assignee)

Comment 13

3 years ago
https://hg.mozilla.org/build/mozharness/rev/8af374186284
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.