1055596 - Add command line options to web-platform-tests for crash reporting.

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[James Graham [:jgraham]]

These are currently missing, so we don't get stack traces.

Comment 1

[James Graham [:jgraham]]

Attachment: Add crash reporting settings to web-platform-tests

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8475233 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Review of attachment 8475233 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/web_platform_tests.py
@@ +120,5 @@
> +                self.fatal("self.installer_url was not found in self.config")
> +            self.info("setting symbols_url as %s" % (symbols_url))
> +            self._symbols_path = symbols_url
> +
> +        return self._symbols_path

Can we just call http://hg.mozilla.org/build/mozharness/file/63ab82be25bc/mozharness/mozilla/testing/testbase.py#l116 instead?

Comment 3

[James Graham [:jgraham]]

Attachment: Add crash reporting settings to web-platform-tests

Apparently we can (desktop_unittest.py probably should too...)

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8475546 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Review of attachment 8475546 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[James Graham [:jgraham]]

https://hg.mozilla.org/build/mozharness/rev/6950bcd5c54b

Comment 6

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8475546 [details] [diff] [review]
Add crash reporting settings to web-platform-tests

Merged to production: https://hg.mozilla.org/build/mozharness/rev/7771c9623c92

Comment 7

[James Graham [:jgraham]]

Attachment: Fix crash reporting for web-platform-tests

So the previous patch had the minor problem that it didn't actually
work because the stackwalk binary location wasn't set. This patch
assumes that will be set in the in-tree config and passed as a command
line option to wptrunner.

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8475836 [details] [diff] [review]
Fix crash reporting for web-platform-tests

Review of attachment 8475836 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with one nit.

::: scripts/web_platform_tests.py
@@ +152,5 @@
>  
>          parser = StructuredOutputParser(config=self.config,
>                                          log_obj=self.log_obj)
>  
> +        env = {'MINIDUMP_SAVE_PATH': self.query_abs_dirs()['abs_blob_upload_dir']}

nit: the 'dirs' variable already stores the result of query_abs_dirs.

Comment 9

[James Graham [:jgraham]]

https://hg.mozilla.org/build/mozharness/rev/f3c0437d982d

Comment 10

[Simone Bruno [:simone]]

In production with reconfig on 2014-08-20 07:47 PT

Comment 11

[James Graham [:jgraham]]

Attachment: Make sure that stackwalk binary is installed when running web-platform-tests

So the previous attachment didn't actually cause the stackwalk binary to be installed. I assumed this was part of the base install on test slaves because I didn't see any code in desktop_unittests to deal with it (and I still don't so I am somewhat confused about why that works...). It turns out that TestingMixin already has code to do this, however and by invoking that I can get stack dumps when running this on my loal machine. So I am moderately convinced that this will actually work.

Comment 12

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8476595 [details] [diff] [review]
Make sure that stackwalk binary is installed when running web-platform-tests

Review of attachment 8476595 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 13

[James Graham [:jgraham]]

https://hg.mozilla.org/build/mozharness/rev/8af374186284