Closed Bug 1055643 Opened 5 years ago Closed 5 years ago

System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument

Categories

(Firefox :: Sync, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

I noticed this warning early on during a mochitest run:
{
12 INFO System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument
}

Relevant source code:
> 395   stripHeaderAttributes: function(value) {
> 396     let value = value || "";

http://mxr.mozilla.org/mozilla-central/source/services/crypto/modules/utils.js?rev=6e77dfcf5c6e&mark=395-396#395

We just want to drop the "let" there, I think.
Attached patch fix v1Splinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8475269 - Flags: review?(ckarlof)
Attachment #8475269 - Flags: review?(ckarlof) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/ecc9477045c7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
FWIW this probably bitrotted one of the patches in bug 1001090.
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.