System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument

RESOLVED FIXED in mozilla34

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

unspecified
mozilla34
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I noticed this warning early on during a mochitest run:
{
12 INFO System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument
}

Relevant source code:
> 395   stripHeaderAttributes: function(value) {
> 396     let value = value || "";

http://mxr.mozilla.org/mozilla-central/source/services/crypto/modules/utils.js?rev=6e77dfcf5c6e&mark=395-396#395

We just want to drop the "let" there, I think.
(Assignee)

Comment 1

3 years ago
Created attachment 8475269 [details] [diff] [review]
fix v1
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8475269 - Flags: review?(ckarlof)
Attachment #8475269 - Flags: review?(ckarlof) → review+
Thanks!
(Assignee)

Comment 3

3 years ago
Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc9477045c7
Flags: in-testsuite-

Comment 4

3 years ago
https://hg.mozilla.org/mozilla-central/rev/ecc9477045c7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
FWIW this probably bitrotted one of the patches in bug 1001090.
You need to log in before you can comment on or make changes to this bug.