Closed Bug 1055650 Opened 10 years ago Closed 10 years ago

WARNING resource://gre/modules/ContentPrefService2.jsm:670 - variable sql redeclares argument

Categories

(Toolkit :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Noticed this warning in my terminal, early on in a local mochitest run:
{
13 INFO System JS : WARNING resource://gre/modules/ContentPrefService2.jsm:670 - variable sql redeclares argument
}

Relevant code:
> 669   _stmt: function CPS2__stmt(sql /*, sql2, sql3, ... */) {
> 670     let sql = joinArgs(arguments);

Given that "sql"-the-function-arg is never directly used, by name, I suspect we might want to rename it "sql1", to fit with the comment about sql2, etc.
Attached patch fix v1Splinter Review
Attachment #8475295 - Flags: review?(adw)
Comment on attachment 8475295 [details] [diff] [review]
fix v1

Review of attachment 8475295 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks Daniel.
Attachment #8475295 - Flags: review?(adw) → review+
Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8adc8ca61b
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/3c8adc8ca61b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.