Closed
Bug 1055650
Opened 10 years ago
Closed 10 years ago
WARNING resource://gre/modules/ContentPrefService2.jsm:670 - variable sql redeclares argument
Categories
(Toolkit :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
1.29 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
Noticed this warning in my terminal, early on in a local mochitest run:
{
13 INFO System JS : WARNING resource://gre/modules/ContentPrefService2.jsm:670 - variable sql redeclares argument
}
Relevant code:
> 669 _stmt: function CPS2__stmt(sql /*, sql2, sql3, ... */) {
> 670 let sql = joinArgs(arguments);
Given that "sql"-the-function-arg is never directly used, by name, I suspect we might want to rename it "sql1", to fit with the comment about sql2, etc.
Assignee | ||
Comment 1•10 years ago
|
||
MXR link: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/contentprefs/ContentPrefService2.jsm?rev=84d14acbb09b&mark=669-670#659
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8475295 -
Flags: review?(adw)
Comment 3•10 years ago
|
||
Comment on attachment 8475295 [details] [diff] [review] fix v1 Review of attachment 8475295 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks Daniel.
Attachment #8475295 -
Flags: review?(adw) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8adc8ca61b
Flags: in-testsuite-
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3c8adc8ca61b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•