1055650 - WARNING resource://gre/modules/ContentPrefService2.jsm:670 - variable sql redeclares argument

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed this warning in my terminal, early on in a local mochitest run:
{
13 INFO System JS : WARNING resource://gre/modules/ContentPrefService2.jsm:670 - variable sql redeclares argument
}

Relevant code:
> 669   _stmt: function CPS2__stmt(sql /*, sql2, sql3, ... */) {
> 670     let sql = joinArgs(arguments);

Given that "sql"-the-function-arg is never directly used, by name, I suspect we might want to rename it "sql1", to fit with the comment about sql2, etc.

Comment 1

[Daniel Holbert [:dholbert]]

MXR link: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/contentprefs/ContentPrefService2.jsm?rev=84d14acbb09b&mark=669-670#659

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8475295 [details] [diff] [review]
fix v1

Review of attachment 8475295 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks Daniel.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8adc8ca61b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3c8adc8ca61b