Closed
Bug 1055657
Opened 11 years ago
Closed 10 years ago
Need widget branding icons for Aurora, Beta, and Release
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 verified, firefox36 verified, fennec35+)
VERIFIED
FIXED
Firefox 36
People
(Reporter: wesj, Assigned: Margaret)
References
Details
Attachments
(2 files)
183.73 KB,
application/zip
|
Details | |
172.45 KB,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We checked in a Nightly icon in bug 1050403 without resources for the rest of our releases. I put in a fake image for them so that the builds don't crash, but we need real images. Alternatively, I guess we can copy the current branding images over.
Updated•11 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → alam
tracking-fennec: ? → 35+
Assignee | ||
Comment 3•11 years ago
|
||
wesj, can you write the patch for this?
Flags: needinfo?(wjohnston)
Comment 5•11 years ago
|
||
This is now on Aurora with Nightly branding.
Assignee | ||
Updated•11 years ago
|
Assignee: alam → wjohnston
Assignee | ||
Comment 6•10 years ago
|
||
So. Many. Icons.
I didn't make a branded build to test, but I assume this will work.
Assignee: wjohnston → margaret.leibovic
Attachment #8513892 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(wjohnston)
Comment 7•10 years ago
|
||
Comment on attachment 8513892 [details] [diff] [review]
Add branding icons for search widget
Make sure we pngcrush / pngquant these
Attachment #8513892 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6ca435a5a803
I used pngcrush on the images.
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8513892 [details] [diff] [review]
Add branding icons for search widget
Approval Request Comment
[Feature/regressing bug #]: search widget
[User impact if declined]: widget has nightly branding
[Describe test coverage new/current, TBPL]: no test coverage, baked on m-c
[Risks and why]: low-risk, swapping some images
[String/UUID change made/needed]: none
Attachment #8513892 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8513892 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•10 years ago
|
||
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
Comment 12•10 years ago
|
||
Verified as fixed in builds:
- 36.0a1 2014-11-27;
- 35.0a2 2014-11-27;
Device: Samsung Galaxy Tab 2 (Android 4.2.2).
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•