Open Bug 1055674 (ruby-merge) Opened 5 years ago Updated Last year

implement CSS 'ruby-merge' property

Categories

(Core :: Layout: Ruby, defect)

defect
Not set

Tracking

()

People

(Reporter: dbaron, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

I'm filing this as a bug on implementing the CSS ruby-merge property:
http://dev.w3.org/csswg/css-ruby/#collapsed-ruby

I think we probably don't need to do this in order to ship CSS Ruby, although I'm willing to entertain arguments to the contrary.
This seems to be an experimental property, and possibly be changed in the future. Hence I guess we probably should give this and ruby-align another pref to control, so that we can switch off them easily without blocking shipping the main part of ruby.
Maybe something like "layout.css.ruby.advanced.enabled"? Or "layout.css.ruby-merge.enabled"?
Flags: needinfo?(dbaron)
Depends on: 1121337
Why implement it now?  Why not just wait?

(That said, where is it described as experimental?)
Flags: needinfo?(dbaron)
(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #3)
> Why implement it now?  Why not just wait?
> 
> (That said, where is it described as experimental?)

Because this spec is still far from RC. Doesn't that mean the whole spec is experimental? I guess the main part of ruby is probably fine to ship directly once the left bug is solved, but I'm not sure about other parts. Should we also ship this property when we enable css-ruby by default?
Flags: needinfo?(dbaron)
I don't think this seems necessary to ship ruby by default?  Do you?  (Do other ruby implementations have it?)
Flags: needinfo?(dbaron)
(In reply to David Baron [:dbaron] (UTC-8) (needinfo? for questions) from comment #5)
> I don't think this seems necessary to ship ruby by default?  Do you?  (Do
> other ruby implementations have it?)

Other implementations do not implement the W3C model at all, hence they don't need this.
What is it that needs this property that the other implementations already do, but the current spec doesn't do without this property?
Nothing. Once we solve the vertical sizing problem (bug 1055662), I believe we are able to do anything other impls can.

If we don't want ruby-merge to be shipped with ruby, I guess we need a new pref for it. Although I feel it is a useful feature, Koji told me it was relatively lower priority, and it could even be deferred to level 2 if we request. Maybe we shouldn't bother to implement it now...
It's better to work on the things we need in order to enable the current pref in shipping builds than to add a new pref for yet more features; I'd say just put this one aside for now.
Hmm, but we have nearly done enabling the current css-ruby pref. We only have the vertical sizing thing left. (Probably also line breaking rules)
Component: Layout: Block and Inline → Layout: Ruby
You need to log in before you can comment on or make changes to this bug.