1055675 - Build fixes for trace-malloc on Windows

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Windows debug builds with trace-malloc fail on MSVC 2010 as follows:

 4:09.29 nsTypeInfo.cpp
 4:09.29 C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\typeinfo
(157) : error C2504: 'exception' : base class undefined
 4:09.29 C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\typeinfo
(161) : error C2614: 'std::bad_cast' : illegal member initialization: 'exception
' is not a base or member
 4:09.29 C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\typeinfo
(178) : error C2504: 'exception' : base class undefined
 4:09.29 C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\typeinfo
(182) : error C2614: 'std::bad_typeid' : illegal member initialization: 'excepti
on' is not a base or member
 4:09.30

trace-malloc is needed for deadlock detection (see bug 939231) and because that bug stalled, it doesn't look like bug 1014341 is happening soon. So it's still useful to fix.

From some analysis, this appears to be a bug in the Windows headers that occurs when compiling with exceptions disabled.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. fix-windows-trace-malloc

This works around the MSVC2010 bug and shouldn't affect other platforms negatively.

Comment 2

[Benjamin Smedberg]

I'll bet you the problem is that we aren't using the CRT wrapper http://mxr.mozilla.org/mozilla-central/source/config/msvc-stl-wrapper.template.h for <typeinfo>

Does it work to add typeinfo to http://mxr.mozilla.org/mozilla-central/source/config/stl-headers?

Otherwise please include a brief comment about why we're including <exception> in this context.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Nope. I do think it's an actual bug in that header: if HAS_EXCEPTIONS is not defined, it won't include <exception> but then try to derive a class from exception a few lines later.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. v2 fix-windows-trace-malloc

Comment 5

[Benjamin Smedberg]

Comment on attachment 8475415 [details] [diff] [review]
Patch 1. v2 fix-windows-trace-malloc

ah ok

Comment 6

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/436085b283b4

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/436085b283b4