1055699 - [MTP] integrate volume isRemovable status

Status: RESOLVED FIXED

(Firefox OS Graveyard :: MTP/UMS, defect)

Description

[Dave Hylands [:dhylands]]

Once bug 1033952 lands, then we should propagate that knowledge into MozMtpStorage::StorageAvailable

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: bug1055699_integate_volume_isRemovable_status

Integrate volume isRemovable status while creating corresponding MozMtpStorage

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8540708 [details] [diff] [review]
bug1055699_integate_volume_isRemovable_status

Review of attachment 8540708 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the change to use IUsHotSwappable

My apologies for the time it took to get this review done.

::: dom/system/gonk/MozMtpStorage.cpp
@@ +101,5 @@
> +  mMtpStorage.reset(new MtpStorage(mStorageID,                           // id
> +                                   mountPoint.get(),                     // filePath
> +                                   mVolume->NameStr(),                   // description
> +                                   1024uLL * 1024uLL,                    // reserveSpace
> +                                   mVolume->IsRemovable(),               // removable

Since there is IsHotSwappable and IsRemovable (I was thinking that only IsRemovable would be implemented when I wrote this bug), this should call IsHoptSwappable()

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1055699:integate_volume_isRemovable_status. r=dhylands.

Integrating volume isRemovable status into MtpStorage creation. 
Using IsHotSwappable to replace IsRemovable.

Comment 4

[Eden Chuang[:edenchuang]]

Comment on attachment 8552978 [details] [diff] [review]
Bug 1055699:integate_volume_isRemovable_status. r=dhylands.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): An enhancement for giving the correct removable status in MTP database
User impact if declined: No, just an enhancement.
Testing completed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=860b0d30a080
Risk to taking this patch (and alternatives if risky): low risky. No impact on any original functions. 
String or UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/74825a55edea

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74825a55edea