Closed
Bug 1055713
Opened 11 years ago
Closed 11 years ago
Entering a URL when in a browser window should navigate the current browser window
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S3 (29aug)
People
(Reporter: benfrancis, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Currently entering a URL into the Rocketbar when you're in a browser window will always launch a new browser window. The spec says it should navgiate the current window if the current window is a browser window.
|
||
Updated•11 years ago
|
Flags: in-moztrap?(mozillamarcia.knous)
|
Assignee | |
Comment 1•11 years ago
|
||
Taking this.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S3 (29aug)
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Might not depend on bug 1054215 after all.
No longer depends on: 1054215
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8480700 [details] [review]
Github pull request
Another window manager thing for you guys to review. When we get a window open request and a browser is up, we should redirect that browser.
Attachment #8480700 -
Flags: review?(alive)
Attachment #8480700 -
Flags: review?(21)
|
||
Updated•11 years ago
|
Attachment #8480700 -
Flags: review?(alive)
Attachment #8480700 -
Flags: review?(21)
Attachment #8480700 -
Flags: review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks Alive. This is landed now: https://github.com/mozilla-b2g/gaia/commit/7616583ebf507860ae22066e38a1205d311400ae
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 6•11 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #4)
> Another window manager thing for you guys to review. When we get a window
> open request and a browser is up, we should redirect that browser.
Just to confirm (because that sounds weird)...
You should only re-use the current browser window if the user type in a URL and hits enter. A window.open(), <a target="_blank"> or view URL web activity should still create a new window, right?
Flags: needinfo?(kgrandon)
|
|
Assignee | |
Comment 7•11 years ago
|
||
(In reply to Ben Francis [:benfrancis] from comment #6)
> (In reply to Kevin Grandon :kgrandon from comment #4)
> > Another window manager thing for you guys to review. When we get a window
> > open request and a browser is up, we should redirect that browser.
>
> Just to confirm (because that sounds weird)...
>
> You should only re-use the current browser window if the user type in a URL
> and hits enter. A window.open(), <a target="_blank"> or view URL web
> activity should still create a new window, right?
If the request comes from the page, yes - but not from the search app. UX wants all searches, url navigation, and web result clicks from the search app to open in the current browser frame.
The current behavior in master should be correct,but we still need to fix bug 1060191.
Flags: needinfo?(kgrandon)
You need to log in
before you can comment on or make changes to this bug.
Description
•