1055747 - make UI showcase work in chrome so we can avoid standalone visual regressions

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

There are a few firefoxisms in the code that make it UX showcase break in Chrome.  This means we can't use it to tell whether or not we've broken the standalone views during visual uplift work.

Comment 1

[Andrei Oprea [mention me on [e-mail]]]

https://github.com/dmose/gecko-dev/commit/e581f2cf180b3b8d168f93de7c22ce44edc5c3ce#diff-a6a91e7e9061a77c51524138e86c1ed4R150

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Fix Loop UI showcase for Chrome to avoid visual regressions, r=[e-mail]

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8475384 [details] [diff] [review]
Fix Loop UI showcase for Chrome to avoid visual regressions, r=[e-mail]

Review of attachment 8475384 [details] [diff] [review]:
-----------------------------------------------------------------

r=:andreio face-to-face with comments fixed.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

https://hg.mozilla.org/integration/fx-team/rev/a36f90989fcc

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a36f90989fcc

Comment 6

[u279076]

I think this will be covered through basic smoketesting and don't think this needs QA before we release. Please needinfo me to request specific testing.