1055755 - Remove |existing| argument from JSCompartment::wrap

Status: NEW

(Core :: JavaScript Engine, enhancement, P5)

Description

[Eric Faust [:efaust]]

Since billm cleaned up dead compartment GC logic, we no longer need to avoid allocating an object during wrapper remapping, so we can just wrap again and swap every time, instead.

Comment 1

[Eric Faust [:efaust]]

Attachment: Patch

Comment 2

[Eric Faust [:efaust]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/205f8fa00772

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for Android debug jsreftest permafail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/33781a3a5201

https://treeherder.mozilla.org/logviewer.html#?job_id=5128423&repo=mozilla-inbound

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This also apparently made OSX 10.6 reftests frequent-but-not-perma-fail: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=5134450&repo=mozilla-inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Wes Kocher (:KWierso) from comment #4)
> This also apparently made OSX 10.6 reftests

10.6 *debug* - I know it sounds crazy, but the retriggers on inbound paint a pretty conclusive picture about it.