1055764 - crash in java.lang.IllegalStateException: No current media session at com.google.android.gms.internal.gp.dV(Unknown Source)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-f873a113-eb77-4fa2-a07f-d4e762140818.
=============================================================

java.lang.IllegalStateException: No current media session
	at com.google.android.gms.internal.gp.dV(Unknown Source)
	at com.google.android.gms.internal.gp.a(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer$5.a(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer$5.a(Unknown Source)
	at com.google.android.gms.common.api.a$b.b(Unknown Source)
	at com.google.android.gms.common.api.c.a(Unknown Source)
	at com.google.android.gms.common.api.c.b(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer.pause(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer.pause(Unknown Source)
	at org.mozilla.gecko.ChromeCast.pause(ChromeCast.java:239)
	at org.mozilla.gecko.MediaPlayerManager.handleMessage(MediaPlayerManager.java:164)
	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168)
	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2290)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)

Comment 1

[Wesley Johnston (:wesj)]

Do we still see this?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

1 crash in b6

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Bandaid

I'm wrapping these methods in a try-catch for now. We're not smart enough anywhere to handle losing a session anyway, so this just notifies Gecko that something went horribly wrong.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/ce37c5e74882

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8499035 [details] [diff] [review]
Bandaid

I realize that I missed the last beta here (I think?). Noming anyway because this is tracking. If we don't care about beta, someone should decide and remove it.

Approval Request Comment
[Feature/regressing bug #]: Chromecast stuff
[User impact if declined]: Possible crash somehow?
[Describe test coverage new/current, TBPL]: None. Can't test Chromecast stuff very well
[Risks and why]: Low risk. Just wrapping stuff in a try catch.
[String/UUID change made/needed]: none.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Based on comment 2, this looks like a won't fix for 33 as it doesn't even seem worth taking as a ride along. Let's get this into 34 once it's landed on m-c.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce37c5e74882

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8499035 [details] [diff] [review]
Bandaid

Aurora+

Do we need any additional logging to help determine why a video stopped playing?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/41199adb9b70

Comment 10

[Wesley Johnston (:wesj)]

We have plenty. We just don't have any STR for these bugs. I have some rewrites to this code around that I think will help with better session restoration.

Comment 11

[u279076]

I'm marking this bug verified fixed since there are no crashes reported in the last week against Fennec 34/35.