Closed
Bug 1055764
Opened 11 years ago
Closed 11 years ago
crash in java.lang.IllegalStateException: No current media session at com.google.android.gms.internal.gp.dV(Unknown Source)
Categories
(Firefox for Android Graveyard :: Screencasting, defect)
Tracking
(firefox33 wontfix, firefox34+ verified, firefox35 verified, fennec33+)
VERIFIED
FIXED
Firefox 35
People
(Reporter: aaronmt, Assigned: wesj)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
5.85 KB,
patch
|
mfinkle
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-f873a113-eb77-4fa2-a07f-d4e762140818.
=============================================================
java.lang.IllegalStateException: No current media session
at com.google.android.gms.internal.gp.dV(Unknown Source)
at com.google.android.gms.internal.gp.a(Unknown Source)
at com.google.android.gms.cast.RemoteMediaPlayer$5.a(Unknown Source)
at com.google.android.gms.cast.RemoteMediaPlayer$5.a(Unknown Source)
at com.google.android.gms.common.api.a$b.b(Unknown Source)
at com.google.android.gms.common.api.c.a(Unknown Source)
at com.google.android.gms.common.api.c.b(Unknown Source)
at com.google.android.gms.cast.RemoteMediaPlayer.pause(Unknown Source)
at com.google.android.gms.cast.RemoteMediaPlayer.pause(Unknown Source)
at org.mozilla.gecko.ChromeCast.pause(ChromeCast.java:239)
at org.mozilla.gecko.MediaPlayerManager.handleMessage(MediaPlayerManager.java:164)
at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:168)
at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2290)
at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:360)
at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)
Updated•11 years ago
|
Assignee: nobody → wjohnston
tracking-fennec: ? → 33+
Assignee | ||
Comment 3•11 years ago
|
||
I'm wrapping these methods in a try-catch for now. We're not smart enough anywhere to handle losing a session anyway, so this just notifies Gecko that something went horribly wrong.
Attachment #8499035 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #8499035 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8499035 [details] [diff] [review]
Bandaid
I realize that I missed the last beta here (I think?). Noming anyway because this is tracking. If we don't care about beta, someone should decide and remove it.
Approval Request Comment
[Feature/regressing bug #]: Chromecast stuff
[User impact if declined]: Possible crash somehow?
[Describe test coverage new/current, TBPL]: None. Can't test Chromecast stuff very well
[Risks and why]: Low risk. Just wrapping stuff in a try catch.
[String/UUID change made/needed]: none.
Attachment #8499035 -
Flags: approval-mozilla-beta?
Attachment #8499035 -
Flags: approval-mozilla-aurora?
![]() |
||
Comment 6•11 years ago
|
||
Based on comment 2, this looks like a won't fix for 33 as it doesn't even seem worth taking as a ride along. Let's get this into 34 once it's landed on m-c.
status-firefox33:
--- → wontfix
tracking-firefox34:
--- → +
![]() |
||
Updated•11 years ago
|
Attachment #8499035 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
![]() |
||
Updated•11 years ago
|
status-firefox35:
--- → affected
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
![]() |
||
Updated•11 years ago
|
![]() |
||
Comment 8•11 years ago
|
||
Comment on attachment 8499035 [details] [diff] [review]
Bandaid
Aurora+
Do we need any additional logging to help determine why a video stopped playing?
Attachment #8499035 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(wjohnston)
Comment 9•11 years ago
|
||
Assignee | ||
Comment 10•11 years ago
|
||
We have plenty. We just don't have any STR for these bugs. I have some rewrites to this code around that I think will help with better session restoration.
Flags: needinfo?(wjohnston)
![]() |
||
Comment 11•11 years ago
|
||
I'm marking this bug verified fixed since there are no crashes reported in the last week against Fennec 34/35.
Status: RESOLVED → VERIFIED
Flags: qe-verify-
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•