Closed Bug 1055774 Opened 7 years ago Closed 7 years ago

Update lookup for crashreporter.ini for the new v2 bundle structure on OSX

Categories

(Toolkit :: Crash Reporting, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file, 1 obsolete file)

crashreporter.ini moves from Contents/MacOS to Contents/Resources.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attachment #8475417 - Flags: review?(benjamin)
Attachment #8475417 - Flags: review?(benjamin) → review+
Attached patch PatchSplinter Review
Sorry, Benjamin. This was supposed to be the easiest patch of all, but I still managed to mess it up. :-/ The reason why this wasn't immediately obvious is because we first needed the patch in bug 1060652 to be able to run any mochitests at all. After they started running, the tests that relied on CrashSubmit.jsm still failed [1]. This patch fixes these failures [2], since we're now correctly going from Firefox.app/Contents/Resources to Firefox.app/Contents/MacOS to find the crashreporter.app, and then from there to crashreporter.app/Contents/Resources to find the crashreporter.ini.

[1] https://tbpl.mozilla.org/?tree=Oak&rev=1d9158344fc0 (see bc1, bc3 and oth)
[2] https://tbpl.mozilla.org/?tree=Oak&rev=797d19721fee (Please ignore the other failures. Still working on those.)
Attachment #8475417 - Attachment is obsolete: true
Attachment #8483157 - Flags: review?(benjamin)
Attachment #8483157 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/b503560736fa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
You need to log in before you can comment on or make changes to this bug.