1055894 - nsIFrame should provide 'normal' version of the logical coordinate getters

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Seth Fowler [:seth] [:s2h]]

nsFrame exposes GetRect() and GetPosition(), which report information about the frame's size and location. It also exposes GetNormalRect() and GetNormalPosition(), which report the same information as it would be if relative positioning had not been applied. This is used extensively in some parts of the layout code.

We've recently added new logical coordinate getters such as BStart() and GetLogicalPosition(). It would be very useful if we added "normal" variations of these which called GetNormalRect() and GetNormalPosition() under the hood.

Comment 1

[Seth Fowler [:seth] [:s2h]]

I've added a dependency on bug 35168 because the modifications to nsTableFrame::GetLogicalBaseline() added in part 2 are very awkward, and would be made much simpler if we had "normal" logical coordinate getters. We should update that code when we add the getters.

Comment 2

[Seth Fowler [:seth] [:s2h]]

(Actually this depends on bug 35168 anyway, since it adds GetNormalRect(), which we'll probably want to use in this bug.)

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

We've already had GetLogicalNormalPosition().

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1055894 - Add GetLogicalNormalRect() and adapt some callers of GetNormalRect(). r?#layout

This patch makes the API nicer, and shouldn't change the behavior.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7437637d0b5c
Add GetLogicalNormalRect() and adapt some callers of GetNormalRect(). r=emilio

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7437637d0b5c