1055899 - Handle audio decoder resets from a SourceBuffer by switching to the new audio decoder

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Spinning off from bug 1041374.  Addressed review comments from that bug and rearranged the code a bit.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Handle audio decoder resets from a SourceBuffer by switching to the new audio decoder. v2

Comment 2

[cajbir (:cajbir)]

Comment on attachment 8475627 [details] [diff] [review]
Handle audio decoder resets from a SourceBuffer by switching to the new audio decoder. v2

Review of attachment 8475627 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceReader.cpp
@@ +218,5 @@
>      SubBufferDecoder* decoder = mDecoders[i];
>  
> +    const MediaInfo& info = decoder->GetReader()->GetMediaInfo();
> +
> +    double decodeTarget = double(mTimeThreshold) / USECS_PER_S;

We should be able to move this outside the loop I think.

Comment 3

[cajbir (:cajbir)]

Comment on attachment 8475627 [details] [diff] [review]
Handle audio decoder resets from a SourceBuffer by switching to the new audio decoder. v2

Review of attachment 8475627 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceReader.cpp
@@ +238,5 @@
> +      if (info.HasAudio()) {
> +        didSwitch = SwitchAudioReader(mDecoders[i]->GetReader());
> +      }
> +      if (info.HasVideo()) {
> +        didSwitch = SwitchVideoReader(mDecoders[i]->GetReader());

Should these be "didSwitch |=" so we don't lose information if a later decoder doesn't switch?

Comment 4

[Matthew Gregan [:kinetik]]

Yep.  I'll change that and comment 2 on commit.

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16cad9b4140c

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/16cad9b4140c