1055914 - Broken link in CONTRIBUTING.md on GitHub.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Michael Cooper [:mythmon]]

In the GitHub repo there is a file called CONTRIBUTING.md [0]. It as a link about where it file bugs about Gaia. The link is broken and results in a 404 page.

[0] https://github.com/mozilla-b2g/gaia/blob/master/CONTRIBUTING.md

Comment 1

[michiel]

I don't see any links that currently give a 404, but I do see three out of four links in there are either incorrect or redirecting to a new title/location:

* the Boot2Gecko product is now called Firefox OS on bugzilla
* the Gaia/Hacking page is now called Developing Gaia on MDN
* the 'Submitting a patch'  link was not pointing to the right section

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:patch-2 > mozilla-b2g:master

Comment 3

[michiel]

Can someone show me how to request a review for this?

Trying to follow https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed but I see no 'review' dropdown on https://bugzilla.mozilla.org/attachment.cgi?id=8579990&action=edit

Comment 4

[michiel]

Changed r=michielbdejong to r=julien in the commit message, as per irc discussion.

Comment 5

[Julien Wajsberg [:julienw] (PTO -> may 13)]

Comment on attachment 8579990 [details] [review]
[gaia] michielbdejong:patch-2 > mozilla-b2g:master

r=me, let's just fix this commit log !

Comment 6

[Julien Wajsberg [:julienw] (PTO -> may 13)]

gaia master: a3ae7adfee0d2fbf459bfb468c4c4c0c566fcbae

Thanks a lot, this is really useful :)

Comment 7

[Julien Wajsberg [:julienw] (PTO -> may 13)]

Hey Kevin, we found one flaw to autolander here: the contributor couldn't ask a review request from a patch was added by another user.

I don't really know how to fix this but maybe you'd have an idea?

Comment 8

[michiel]

> we found one flaw to autolander here

I think the flaw was not in autolander but in me in this case. :) I hadn't read the submitting-a-patch instructions properly and thought the "r=" was for the committer instead of the reviewer. Thanks for helping me with this, I'll do it right the next time! :)

Comment 9

[Kevin Grandon :kgrandon]

I don't think there is a problem here, but if there is then it's with the bugzilla interface. Contributors should now be able to edit autolander attachments on bugs. Let me know if you can't add a reviewer in the future. Thanks!