1055974 - Enable MP3 decoding in WMF PDM

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We need to be able to handle MP3 contained in MP4 container in the WMF PDM, otherwise we'll ship a feature regression when we turn it on.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Add support for MP3 in WMF PDM.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Let's see what bugs we shake out of MP4Reader:
https://tbpl.mozilla.org/?tree=Try&rev=69f7f1e6c3b4

Comment 3

[Paul Adenot (:padenot)]

The try does not look that great, although I'm wondering if you pushed with a bad base commit, because there are weird stuff in the logs.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

That's not surprising at all. We've never tested the MP4Reader before. And we can't turn it on until it's feature equivalent with the other MP4 backends; that's why we need MP3 support.

Also, I had EME enabled in that build, which the m2 and m3 failures. The test_buffered failure ajones has an r+'d patch for.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb48633330e3