Closed Bug 1056010 Opened 9 years ago Closed 8 years ago

Using a tochange parameter in the UI query string requests 1000 resultsets causing browser hang

Categories

(Tree Management :: Treeherder, defect, P4)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1078209

People

(Reporter: mdoglio, Unassigned)

Details

Apparently the UI set a count of 1000 when requesting resultsets with such a parameter set. I think we should limit the result-set count in both the UI and the service to a maximum of 10 per page.
Priority: -- → P1
Priority: P1 → P3
Summary: Using a tochange parameter in the UI query string results in a browser crash → Using a tochange parameter in the UI query string requests 1000 resultsets causing browser hang
Severity: critical → normal
Priority: P3 → P4
I'm pretty sure this is either fixed already on prod, or shortly will be, once bug 1078209 is deployed. Cameron, could you confirm? :-)
The UI issue is addressed in this commit for bug 1078209:

https://github.com/mozilla/treeherder/commit/7ed4137124831c383127bbd560f32a808c856072

It is still possible to hit the service API directly and get 1000 resultsets.  IMO, this is OK.  The default is 10, and it never allows more than 1000.  The UI can't be coerced to do it.  But perhaps there's an API reason to do it.

So, IMO, we can mark this fixed.  But I don't feel that strongly that we shouldn't lower from 1000.  I DO feel strongly that we should keep it at least 100.  The UI can handle this, and it's needed for when you specify a ``fromchange`` where it is more than 10 pushes old.
Sounds good to me :-)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.