1056054 - crash in java.lang.NullPointerException: at org.mozilla.gecko.ChromeCast$VideoPlayCallback.onMetadataUpdated(ChromeCast.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-17496903-f6f5-4623-a9ab-c81352140819.
=============================================================

ava.lang.NullPointerException
	at org.mozilla.gecko.ChromeCast$VideoPlayCallback.onMetadataUpdated(ChromeCast.java:82)
	at com.google.android.gms.cast.RemoteMediaPlayer.onMetadataUpdated(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer.b(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer$1.onMetadataUpdated(Unknown Source)
	at com.google.android.gms.internal.gp.a(Unknown Source)
	at com.google.android.gms.internal.gp.ai(Unknown Source)
	at com.google.android.gms.cast.RemoteMediaPlayer.onMessageReceived(Unknown Source)
	at com.google.android.gms.internal.gi$1$4.run(Unknown Source)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5086)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: cc2

We don't actually do anything in onMetadataUpdated, so lets just not crash there either.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8477569 [details] [diff] [review]
cc2

Noming these now because fx-team is closed, but I want to make sure they're ready for uplift ASAP.

Approval Request Comment
[Feature/regressing bug #]: Chromecast
[User impact if declined]: Might crash if this is called.
[Describe test coverage new/current, TBPL]: working on it
[Risks and why]: This is very low risk. Removing dead code.
[String/UUID change made/needed]: none

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d7a9e478db1d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7a9e478db1d

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a0ab10a147e