1056087 - contrib/merge-users.pl fails if there are no duplicate bug_user_last_visit rows

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P1)

Description

[:glob ✱]

contrib/merge-users.pl fails if there are no duplicate bug_user_last_visit rows:

DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 [for Statement "DELETE FROM bug_user_last_visit WHERE  id IN () "] at ./contrib/merge-users.pl line 179.

Comment 1

[Frédéric Buclin]

$dbh->do("DELETE FROM bug_user_last_visit WHERE " . $dbh->sql_in('id', $dupe_ids));

It should only be called if @$dupe_ids is not empty.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1056087-v1.patch

This adds a check to only delete if there are duplicate ids, it also reformats one line that was contrary to the bugzilla code guidelines (line length limit: 80 chars)

Comment 3

[:glob ✱]

Comment on attachment 8476716 [details] [diff] [review]
bug-1056087-v1.patch

Review of attachment 8476716 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob by inspection

Comment 4

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/bugzilla/bugzilla.git
   0922b44..8234603  master -> master

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b086258..f95d295  master -> master